develooper Front page | perl.wxperl.users | Postings from July 2022

[rt.cpan.org #143774] [PATCH] Explicitly return a string SV fromWx::InputStream::READLINE

Thread Next
From:
gregor herrmann via RT
Date:
July 17, 2022 18:58
Subject:
[rt.cpan.org #143774] [PATCH] Explicitly return a string SV fromWx::InputStream::READLINE
Message ID:
rt-5.0.2-6005-1657911958-284.143774-15-0@rt.cpan.org
Fri Jul 15 15:05:58 2022: Request 143774 was acted upon.
Transaction: Ticket created by GREGOA
       Queue: Wx
     Subject: [PATCH] Explicitly return a string SV from Wx::InputStream::READLINE
   Broken in: (no value)
    Severity: (no value)
       Owner: Nobody
  Requestors: gregoa@cpan.org
      Status: new
 Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=143774 >


In Debian we are currently applying the following patch to Wx.
We thought you might be interested in it too.

From 41bcb4f309b5a8f13dfa9c6d417369938cbe6060 Mon Sep 17 00:00:00 2001
From: Niko Tyni <ntyni@debian.org>
Date: Sun, 10 Jul 2022 16:53:10 +0100
Subject: [PATCH] Explicitly return a string SV from Wx::InputStream::READLINE

Perl 5.35.9 changed SV integer / string handling slightly, resulting in
the return value from READLINE() to evaluate as false regardless of its
string contents, because it is initially created as the integer 0 and no
longer gets marked as a valid string. This broke the Wx-Perl-ProcessStream
distribution test suite.

Fix the regression by explicitly setting SvPOK on the return value,
mirroring the sibling READ() method.

Bug-Debian: https://bugs.debian.org/1014295

The patch is tracked in our Git repository at
https://salsa.debian.org/perl-team/modules/packages/libwx-perl/raw/master/debian/patches/0001-Explicitly-return-a-string-SV-from-Wx-InputStream-RE.patch

Thanks for considering,
  gregor herrmann,
  Debian Perl Group


Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About