Front page | perl.vmsperl |
Postings from October 2002
Jordan Henderson wrote:
!Peter,
!
!Failing at test 2 in t/pod/find, huh?
!
!That's the same place that I had a failure that is discussed in the
attached.
!Haven't gotten around to putting together a patch yet.
!
!Could you try that code change to the test recommended in the attached
email and
!see if this corrects it? It was a great puzzle to me that I was the only
one
!experiencing this behavior from what I believe is an improper use of
Perl's
!grep.
!
!Jordan Henderson
Your suggested fix solved the problem. Here it is a
unified diff against perl 5.8.0:
--- t/pod/find.t;-1 Sat Jun 1 17:03:50 2002
+++ t/pod/find.t Mon Oct 14 13:10:00 2002
@@ -48,8 +48,8 @@
my $count = 0;
my @result = split(/,/,$result);
my @compare = split(/,/,$compare);
- foreach(@compare) {
- $count += grep {/$_/} @result;
+ foreach $compare (@compare) {
+ $count += grep {/$compare/} @result;
}
ok($count/($#result+1)-1,$#compare);
}
End of Patch.
I note that the difference between the t/pod/find.t file
that shipped with perl 5.8.0 and the perl@17882 devel
kit of perl 5.9.0 is null, hence that patch might apply
cleanly to the mainline of perl development.
Unfortunately I do not know where the newer kits are
kept and perl@17882 was the most recent kit posted
to ftp://ftp.funet.fi/pub/languages/perl/snap/.
To get any closer to the mainline might require a
perforce client or an rsync client (perforce is free
for open source work and has been ported to VMS).
At any rate thanks for the suggestion, try mailing that
patch in to p5p.
Peter Prymmer
Thread Previous