develooper Front page | perl.tcltk | Postings from July 2018

Superseded patch for Tcl::Tk t/text.t

Thread Next
From:
Christopher Chavez
Date:
July 14, 2018 22:28
Subject:
Superseded patch for Tcl::Tk t/text.t
Message ID:
49CE71F7-AEDB-4133-92AA-F35274511331@gmx.us
A few days ago, I noticed how text.t would be skipped due to "no tklib extension available" even if tklib was installed. I found that changing `pkg_require('scrolledwindow')` to `pkg_require('widget::scrolledwindow')` got it working.

I had come up with the following patch and was about to open a pull request, but then 1.12 was released with snit included, so the very test for scrolledwindow I had patched was removed.

Just sending this along for reference.


diff --git a/t/text.t b/t/text.t
index f497bd5..94ea184 100755
--- a/t/text.t
+++ b/t/text.t
@@ -10,7 +10,7 @@ if ($^O ne 'MSWin32' and !$ENV{DISPLAY}) {

 my $mw = Tcl::Tk::MainWindow->new;

-if (!$mw->interp->pkg_require('scrolledwindow')) {
+if (!$mw->interp->pkg_require('widget::scrolledwindow')) {
     print "1..0 # skip: no tklib extension available\n";
     exit;
 }

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About