Front page | perl.perl6.internals |
Postings from September 2005
On Sep 24, 2005, at 9:04 AM, Leopold Toetsch wrote: > > On Sep 24, 2005, at 17:30, Ross McFarland wrote: > > >> >> >> On Sep 24, 2005, at 4:59 AM, Leopold Toetsch wrote: >> >> > > >>> - I don't understand the extra check: >>> + if (path) >>> + goto done; >>> >> >> extra as in one last or extra as in why i'm checking at all? >> > > The test 'if (path)'. Before that is an 'if' that checks, if > library loading was ok. Therefore I don't understand this line. The > goto to the cleanup part is fine. oh, crap, heh. i used to have a function called try_load that was called in place of the actual load and the if path's checked it's return value. when i realized i didn't want to be calling the runtime stuff that function shrunk to almost nothing. i got rid of the function and put the remaining code in it's place as the last thin i did before submit the original patch. i guess i didn't look close enough at the result of that. new patch attached shortly resolving the oversight. thanks, -rmThread Previous | Thread Next