Front page | perl.perl6.internals |
Postings from September 2005
On Sep 24, 2005, at 4:59 AM, Leopold Toetsch wrote: > > On Sep 24, 2005, at 6:36, Ross McFarland wrote: > > >> >> >> On Sep 22, 2005, at 10:51 PM, Ross McFarland wrote: >> >> >>> >>> i was playing around with NCI stuff tonight and ran across a >>> problem in loadlib. the following code does not work: >>> >> >> for those of you interested: >> https://rt.perl.org/rt3/Ticket/Display.html?id=37258 >> > > This patch seems to simplify things. Two remarks: > - use mem_sys_allocate() instead of malloc - it deals w out-of-mem i was only using what was there before. this is the first time i've touched parrot and don't yet know anything about it outside of that file. > - I don't understand the extra check: > + if (path) > + goto done; extra as in one last or extra as in why i'm checking at all? the reason i went ahead and put it on the last one was so that other tries could be put in on the end without breaking that one, it doesn't hurt to do the extra goto.0 the reason i'm doing that in the first place was just to quit trying and unify the cleanup code. >> >> i'll work on porting the pir to a .t test at some point if that >> would be desirable. >> > > Tests are very welcome albeit a bit non-trivial as platforms and > availability of libs most be taken into account. it's been suggested that i use libcni_test which will always be around. that should work, but it still will probably be somewhat complicated. -rmThread Previous | Thread Next