develooper Front page | perl.perl6.internals | Postings from October 2002

Re: [perl #17903] [PATCH] sprintf test

Thread Previous | Thread Next
From:
Steve Fink
Date:
October 17, 2002 00:10
Subject:
Re: [perl #17903] [PATCH] sprintf test
Message ID:
20021017070757.GF2030@foxglove.digital-integrity.com
On Wed, Oct 16, 2002 at 09:19:45PM +0100, Nicholas Clark wrote:
> On Mon, Oct 14, 2002 at 12:09:54AM +0000, Simon Glover wrote:
> >  Here's a brief test for the PMC, PMC, PMC form of the sprintf op;
> >  as an added bonus, it also tests two of the formats not previously
> >  tested (%b and %o).
> 
> Thanks, applied

Can you (and everyone else) also update RT when applying patches? The
process, as I understand it, is:

1. Apply the patch

2. Say some variant of "Thanks, applied" to the list. (I put this here
because if you're going to do this, it must be done BEFORE the
following steps.)

3. If the patch has a ticket number associated with it, find it in the
list at <http://www.parrotcode.org/openpatches>. Click on the
appropriate ticket link.

4. Click on the "Basics" link.

5. Set the "Patch Status" to "Applied".

6. Optionally, also set the "status" dropdown to "resolved". A patch
is resolved if there aren't any lingering issues that need to be
addressed -- the most common of which would be the lack of a test
case. (So any patch that includes a test case, or is only a test case,
should nearly always be marked as resolved. For others, use your
judgement as to whether or not it needs a test.)

7. Click on submit.

I don't know exactly who has the permissions to do these things, but
I'm pretty sure that if you have commit access then you also have RT
futzing access. If this is too much trouble, then don't worry about it
-- I'm slowly working through the patch queue, and I'll do it when I
make it to the ticket in question. And getting patches applied is much
more important than maintaining accurate RT state!

To explain the comment in #2 -- currently, RT helpfully re-opens a
ticket if there is further discussion after the ticket is closed
(resolved). So if you do the RT stuff first, and then send a "Thanks,
applied" message to the list, Mr. RT_System will reset the status to
"Open". Robert's going to disable this eventually, but he is currently
laboring under the misconception that his life involves a purpose
other than maintaining software for Parrot. I'm sure he'll return to
insanity soon, but even then he has some other stuff to get to first.

Thanks!

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About