develooper Front page | perl.perl5.porters | Postings from June 2022

Checking authors t/porting/authors.t

Thread Next
From:
Nicolas Mendoza
Date:
June 16, 2022 00:44
Subject:
Checking authors t/porting/authors.t
Message ID:
c6203a39-78de-1b79-ff92-b0d2aadf7998@pvv.ntnu.no
Hi, I think it seems I may have gotten my first pull request accepted 
into blead, which is great. (yay!)

What is slightly less great is that both the github action tests on my 
own branch and in blead fail. The reasons seems to be t/porting/authors.t

I see there has been a lot of work in getting it to work just right to 
make sure all authors are included as it should be, and also lessen some 
burden on actual releases.

But, if we want to lower the threshold for anyone to contribute to 
perl5, would it make more sense that it generated an authors file, or if 
possible had some kind of pre-commit hook?

At the very least, perhaps the test should barf with how to exactly add 
oneself to the AUTHORS file to make the test to pass? (I'll probably 
send a PR for exactly that thinking of it as I write this. But perhaps 
there is a better way?)

-- 

Nicolas Mendoza


Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About