develooper Front page | perl.perl5.porters | Postings from February 2022

Re: De-experimenting signatures - the PR

Thread Previous | Thread Next
From:
Paul "LeoNerd" Evans
Date:
February 18, 2022 15:53
Subject:
Re: De-experimenting signatures - the PR
Message ID:
20220218155241.701b752d@shy.leonerd.org.uk
On Tue, 15 Feb 2022 22:54:10 +0000
"Paul \"LeoNerd\" Evans" <leonerd@leonerd.org.uk> wrote:

> Here it is,
> 
>   https://github.com/Perl/perl5/pull/19424

I had imagined there'd be more PR review comments by now ... ;)

For such a big important and anticipated change, there's been seemingly
little review.

I'll remind folks: This PR is 98% about documentation and unit-tests.
There's *one* 4-line chunk of actual code change, and that is simply
deleting the 4 lines of C code that calls the Perl_ck_warner_d function
which actually prints the warning. The entire rest of the PR is updates
to documentation (plain English, no code), unit tests, or other related
files (plain perl). So it really doesn't need an expert in C or core
perl internals; anyone at all can comment about the documentation at
least.

We're aiming to get this one merged in time for the 5.35.9 release this
Sunday.

-- 
Paul "LeoNerd" Evans

leonerd@leonerd.org.uk      |  https://metacpan.org/author/PEVANS
http://www.leonerd.org.uk/  |  https://www.tindie.com/stores/leonerd/

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About