Front page | perl.perl5.porters |
Postings from February 2022
On Mon, 14 Feb 2022 at 04:26, demerphq <demerphq@gmail.com> wrote: > On Fri, 21 Jan 2022 at 17:19, Dave Mitchell <davem@iabyn.com> wrote: > >> On Sun, Jan 16, 2022 at 02:40:09PM -0500, Ricardo Signes wrote: >> > Hello, I am joining this thread way up at the top, because the bottom >> > looks like it's gotten pretty sticky. >> >> Hello, thought I'd join you up here where the air is clear and the views >> spectacular! >> >> > On the other hand, I think everybody basically agrees that the "fixed" >> > behavior is preferable >> >> ribasushi, shadowcat-mst and Vincent Pit in the ticket for 'BBC breaks >> DBIx:Class' (#17663), all seemed to think my patch was in some way >> philosophically wrong, but to varying degrees agreed to work around it if >> we insisted on (eventually) un-reverting it. >> >> So I think we could do with a bit more discussion, which I will seed >> below. But my opinion so far is that my patch is correct and should be >> applied, but directly after 5.36.0 is released, to give distro owners max >> time to fix things up. >> > > I would like to get it released in 5.36.0 as a build option. I know people > who would use that build option and are backporting your original patch and > if there are conflicts I would like to get it resolved. More specifically > Booking has been backporting your patch ever since you wrote it, to perls > from before when you wrote it. Thus a long time, (with no issue mind you). > Even though I don't work at Booking any more I would like to get this > sorted out so my friends and colleagues there do not have to deal with it. > > I would be happy to write the required code. > For now I have created https://github.com/Perl/perl5/pull/19415 which reverts the revert, with conflicts resolved. I kinda wonder if we should reduce it to two patches however, one was a fix for the other, if we reapply we might as well squash them down. I have not implemented a define flag to enable the corrected behaviour yet. Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"Thread Previous | Thread Next