Front page | perl.perl5.porters |
Postings from February 2022
On Sat, 12 Feb 2022 at 06:00, demerphq <demerphq@gmail.com> wrote: > On Fri, 11 Feb 2022 at 18:26, Hugo van der Sanden < > notifications@github.com> wrote: > >> #reordered comments > >> pod/perlreguts.pod has some references to "offsets" that should mostly >> be removed (found by grepping for /mjd/i). >> > > Done, also your other comment is resolved too. I had to completely update > the regexp_internal documentation in perlreguts.pod. > > regcomp.h defines MJD_OFFSET_DEBUG, is that still required? I see it also >> appears in ppport.h. If these are retained intentionally, they might >> merit mention in the commit message. >> > > Gnash, I think I missed this one in my force push I just did to resolve > your comments. I am digging into something else, Ill check it later today. > > I just force pushed again with a bunch of further fixes related to this, thanks Hugo! However I do not know what to do about this: $ git grep OFFSET_DEBUG dist/Devel-PPPort/parts/base/5009004:MJD_OFFSET_DEBUG # Z added by devel/scanprov $ git grep OFFSETS dist/Devel-PPPort/parts/base/5009002:DEBUG_OFFSETS_r # Z added by devel/scanprov dist/Devel-PPPort/parts/base/5009004:RE_DEBUG_EXTRA_OFFSETS # Z added by devel/scanprov dist/Devel-PPPort/parts/base/5009005:RE_TRACK_PATTERN_OFFSETS # Z added by devel/scanprov Should I just remove these? The PPPort instructions are pretty large and I didnt spot instructions for what to do when we *remove* things. Advice appreciated! cheers, Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"