develooper Front page | perl.perl5.porters | Postings from April 2021

Tab indentation to space indentation pull requests

Thread Next
From:
Михаил Козачков
Date:
April 11, 2021 22:07
Subject:
Tab indentation to space indentation pull requests
Message ID:
baa7271f-a2b5-b328-71a7-c22f7c9c5cb1@gmail.com
In pod/perlhack.pod there are such lines:

> =head3 Style
> 
> In general, please follow the particular style of the code you are
> patching.
> 
> In particular, follow these general guidelines for patching Perl
> sources:
> 
> =over 4
> 
> =item *
> 
> 4-wide indents for code, 2-wide indents for nested CPP C<#define>s,
> with 8-wide tabstops.
> 
> =item *
> 
> Use spaces for indentation, not tab characters.
> 
> The codebase is a mixture of tabs and spaces for indentation, and we
> are moving to spaces only.  Converting lines you're patching from 8-wide
> tabs to spaces will help this migration.

Is it acceptable to create pull-requests just for such tab/spaces 
substitutions? If yes for which files the answer is no and why?

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About