develooper Front page | perl.perl5.porters | Postings from July 2020

Re: Smoke Failures on Alpine Linux

Thread Previous
From:
ilmari
Date:
July 30, 2020 19:36
Subject:
Re: Smoke Failures on Alpine Linux
Message ID:
87a6zgiyly.fsf@wibble.ilmari.org
James E Keenan <jkeenan@pobox.com> writes:

> On 6/16/20 1:47 PM, Dagfinn Ilmari Mannsåker wrote:
>
>> Turns out that because of the way struct TM is used, we can make it
>> const regardless of what the system struct tm has.
>>
>> This is now smoking on
>> https://github.com/Perl/perl5/commits/smoke-me/ilmari/struct-tm-const-tm_zone,
>> and has been tested successfully on musl with c++.
>
> Ilmari,
>
> Is the following commit what was intended to solve the problem
> originally reported by Carlos Guevara on June 16?
>
> #####
> commit 926c3ce35a7ef910c55cf0964c39718ef5938ca6
> Author:     Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
> AuthorDate: Tue Jun 16 13:47:35 2020 +0100
> Commit:     Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
> CommitDate: Sat Jul 18 01:28:15 2020 +0100
>
> time64: declare `tm_zone` as `const char*` unconditionally
>
> We only ever assign from `struct tm` to `struct TM`, not the other way
> around, so making this const regardless of what `struct tm` has should
> be safe.
> #####
>
> Thank you very much.
> Jim Keenan

Yes, that's why I posted the PR in the thread, and as noted in the PR
description (but I forgot to put in the commit message):

| This fixes the build under C++ on musl libc and other systems with
| const char *tm_zone that weren't explicitly listed in the conditional.

- ilmari
-- 
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
 the consequences of."                              -- Skud's Meta-Law

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About