develooper Front page | perl.perl5.porters | Postings from February 2020

Re: Scalar-List-Utils 1.54 breaks Win32 builds.

Thread Previous | Thread Next
From:
sisyphus
Date:
February 8, 2020 14:37
Subject:
Re: Scalar-List-Utils 1.54 breaks Win32 builds.
Message ID:
CADZSBj0HyTJrXOB66PFDG=e-4t2aiLMuCeozrjBbbXA4mP3xLw@mail.gmail.com
Cool - I hadn't seen that PR (
https://github.com/Dual-Life/Scalar-List-Utils/pull/98).
Since that's what xenu suggests, then it's quite possibly better than
anything I'll provide.

Cheers,
Rob

On Sun, Feb 9, 2020 at 1:05 AM demerphq <demerphq@gmail.com> wrote:

> On Sat, 8 Feb 2020 at 14:30, sisyphus <sisyphus359@gmail.com> wrote:
>
>> A fix for the trunc() problem is to replace:
>>
>> ret -= trunc(ret);
>> with:
>> #ifdef _MSC_VER
>> ret -= ret > 0 ? floor(ret) : ceil(ret);
>> #else
>> ret -= trunc(ret);
>> #endif
>>
>>>
>>>
> Xenu posted a different patch as a PR against Scalar-List-Util:
>
> https://github.com/Dual-Life/Scalar-List-Utils/pull/98
>
> Please dont forget the commit from my pull request to silence the
> signed/unsigned warnings in List::Util::sample()
>
>
> https://github.com/Dual-Life/Scalar-List-Utils/pull/97/commits/ece2617bb7131d1cc266d6308ebefaf7768b80f1
>
> Cheers,
> Yves
> --
> perl -Mre=debug -e "/just|another|perl|hacker/"
>

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About