develooper Front page | perl.perl5.porters | Postings from February 2020

Kak, accidental push of f8e72076393d9 fix defines forPERL_BITFIELDxx on Linux and Win32

From:
demerphq
Date:
February 8, 2020 11:22
Subject:
Kak, accidental push of f8e72076393d9 fix defines forPERL_BITFIELDxx on Linux and Win32
Message ID:
CANgJU+W3u63_tPw6e=kFjxtZ677BTK4cc4OFS6DD5snwHHYS+Q@mail.gmail.com
While pushing:

commit 4bc1bdabc07d5a0da438705ad804632dbea7805e (HEAD -> blead,
origin/blead, origin/HEAD)
Author: Yves Orton <demerphq@gmail.com>
Date:   Sat Feb 8 11:58:32 2020 +0100

    Revert "Update Scalar-List-Utils to CPAN version 1.54"

    This reverts commit 16933d619ff0a6284a4a90626ab5d39e472c694f.

    This breaks Win32 builds as it does not include trunc(),
    which is causing havoc with our build process. See issue #17550

I didn't realize I had done it on top of:

commit f8e72076393d9d7449840dbf7eb1feb3f9616113
(origin/smoke-me/fix_bitfield_definitions)
Author: Yves Orton <demerphq@gmail.com>
Date:   Sat Feb 8 11:02:08 2020 +0100

    fix defines for PERL_BITFIELDxx on Linux and Win32

    for some reason PERL_BITFIELD32 is defined as "unsigned" which is
    defined to be the same as "unsigned int" which could be 16 bits.

    This changes the definition for PERL_BITFIELDxx to be the same
    on both platforms and to use the full names for the type, and to
    use a type which is guaranteed to be at least 32 bits long for
    PERL_BITFIELD32.

Which was/is a PR I wanted reviewed before pushing. Since it is in now, I
think I will leave it until someone like Dave Mitchel or xenu or well,
anyone other than me who is more comfortable about reasoning about the size
of things like "int" and  "unsigned" types in C.

Really sorry about that. I am totally ok with reverting it, but if we are
going to keep it I didnt want to revert just to have to reapply and clog up
the commit log.

Yves

-- 
perl -Mre=debug -e "/just|another|perl|hacker/"



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About