develooper Front page | perl.perl5.porters | Postings from February 2020

Re: How to bisect for first commit at which a test passes?

Thread Previous | Thread Next
February 2, 2020 03:38
Re: How to bisect for first commit at which a test passes?
Message ID:
James E Keenan <> wrote:
:[perl2] $ ./perl -v | head -2 | tail -1
:This is perl 5, version 31, subversion 3 (v5.31.3) built for 
:[perl2] $ ( cd t ; ./perl op/sprintf2.t >/dev/null ) ; echo $?
:[perl2] $ ( cd t ; ./perl harness op/sprintf2.t >/dev/null ) ; echo $?

Umm, that's 5.31.3, we expected that to pass.

If you get the same with 5.31.2, try the harness invocation without the
'>/dev/null' - if it still reports a non-zero exit status but itself
exits with 0, we should make a ticket to consider whether that's correct
behaviour. (My guess is that it's not correct, but that it would need
a bunch of toolchain work to propagate the information correctly.)

We should do that regardless, but #17521 prompted me to find back #17034 [1],
which coincidentally turns out to be clearly the issue you're looking at.
So you're looking for these commits:
  a06a4d45d4 [perl #134172] restrict scope of locale changes during sprintf
  39b0ad1783 [perl #134172] Avoid multiple checks of IN_LC(LC_NUMERIC)
  061637ca01 [perl #134172] perldelta
.. of which the first is the one your bisect will've been trying to find.



Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About