On Fri, 24 Jan 2020 at 17:13, demerphq <demerphq@gmail.com> wrote: > On Fri, 24 Jan 2020 at 17:10, demerphq <demerphq@gmail.com> wrote: > >> On Fri, 24 Jan 2020 at 17:02, James E Keenan <jkeenan@pobox.com> wrote: >> >>> On 1/24/20 10:22 AM, demerphq wrote: >>> > On Fri, 24 Jan 2020 at 15:14, James E Keenan <jkeenan@pobox.com >>> > <mailto:jkeenan@pobox.com>> wrote: >>> > >>> > >>> > This warning is not present in blead (6568ef8216). Can you correct >>> > this? I will then squash and merge. >>> > >>> > >>> > Hi, >>> > >>> > I went ahead and did the squash as part of fixing the RETVAL thing. >>> It >>> > is pushed as smoke-me/test_hv_macro_squash. >>> > >>> > If it passes your tests I think we are good to merge. Yay! >>> > >>> >>> Not yet ready for merge. When I rebase the >>> smoke-me/test_hv_macro_squash branch on blead, then build and test, I >>> get this test failure: >>> >>> ##### >>> $ cd t;./perl harness -v ../ext/XS-APItest/t/hv_macro.t; cd - >>> >>> ok 1 - use XS::APItest; >>> ok 2 - U8TO16_LE works as expected (hex bytes:12 34) >>> not a 64 bit perl at t/hv_macro.t line 76. >>> ok 3 - U8TO32_LE works as expected (hex bytes:12 34 56 78) >>> # Tests were run but no plan was declared and done_testing() was not >>> seen. >>> # Looks like your test exited with 255 just after 3. >>> Dubious, test returned 255 (wstat 65280, 0xff00) >>> All 3 subtests passed >>> >>> Test Summary Report >>> ------------------- >>> ../ext/XS-APItest/t/hv_macro.t (Wstat: 65280 Tests: 3 Failed: 0) >>> Non-zero exit status: 255 >>> Parse errors: No plan found in TAP output >>> Files=1, Tests=3, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.04 cusr >>> 0.00 csys = 0.04 CPU) >>> Result: FAIL >>> ##### >>> >>> Can you investigate? >>> >> >> Yeah, this is the same issue I mentioned 20 minutes ago. Can you tell me >> how you configured for this build please? Also can you tell me what this >> says? >> >> ./perl -Ilib -MConfig -E'say $Config{ivsize}' >> 8 >> >> I need a reliable way to determine if the Perl has 64 bit integers or not. >> > > In the C code we have: > > #if IVSIZE==8 > #define TEST_64BIT 1 > #else > #define TEST_64BIT 0 > #endif > > in the perl code we have: > > my $is_wide = $Config{ivsize} == 8; > > I was under the impression these two expressions should produce the same > results, but it seems for some builds this is not the case. Not sure what > to do. > I imagine this kind of thing is why people dont write tests for things like this, its just too hard to get right. :-( We need a proper solution for this IMO. Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"Thread Previous | Thread Next