develooper Front page | perl.perl5.porters | Postings from January 2020

Re: Merging smoke-me/test_hv_macro

Thread Previous | Thread Next
January 24, 2020 15:20
Re: Merging smoke-me/test_hv_macro
Message ID:
On Fri, 24 Jan 2020 at 15:21, <> wrote:

> James E Keenan <> wrote:
> :[...] This warning is not present in blead (6568ef8216).  Can you correct
> :this?  I will then squash and merge.
> When squashing, it would be a good idea to change the original commit
> message: "add tests for U8TO64_LE() and other hashing macros and code"
> implies no non-test code changes.
> I'd be inclined to separate the functional changes from the tests to
> give two commits, so the commit for the functional changes is more
> clearly called out. The future will thank us for it.

Good suggestion. So along with fixing the unitialized RETVAL crapola, I
also did this.

It is pushed as smoke-me/test_hv_macro_squash

Thanks for the feedback,

perl -Mre=debug -e "/just|another|perl|hacker/"

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About