develooper Front page | perl.perl5.porters | Postings from January 2020

Re: Merging smoke-me/test_hv_macro

Thread Previous | Thread Next
From:
hv
Date:
January 24, 2020 14:21
Subject:
Re: Merging smoke-me/test_hv_macro
Message ID:
202001241406.00OE65P24621@crypt.org
James E Keenan <jkeenan@pobox.com> wrote:
:[...] This warning is not present in blead (6568ef8216).  Can you correct 
:this?  I will then squash and merge.

When squashing, it would be a good idea to change the original commit
message: "add tests for U8TO64_LE() and other hashing macros and code"
implies no non-test code changes.

I'd be inclined to separate the functional changes from the tests to
give two commits, so the commit for the functional changes is more
clearly called out. The future will thank us for it.

Hugo
Thread Previous | Thread Next

nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About