develooper Front page | perl.perl5.porters | Postings from January 2020

Re: Merging smoke-me/test_hv_macro

Thread Previous | Thread Next
January 24, 2020 06:40
Re: Merging smoke-me/test_hv_macro
Message ID:
On Thu, 23 Jan 2020 at 15:56, James E Keenan <> wrote:

> Unfortunately, this branch experienced a build-time failure on one of
> those continuous-integration thingees we've added in recent months.
> Worse, the build-time failure was on one Windows machine (but apparently
> not the other).
Ok, I have pushed fixes for these issues I believe. The warnings in the
Windows reports were pre-existing, the errors were  new and due to the
version of C being used not being able to handle something like this:

const U8 n = 10;
int i[n];

The warning you noticed was due to a codepath that croaks not setting
RETVAL since it croaks. I changed it to set RETVAL first to silence the

And lastly I added some casts so that if UV was smaller than uint64_t the
compiler would not complain, if UV is smaller than 64 bits we wont enter
those codepaths anyway.

I think this should be good now. But I wonder if we shouldnt squash the
patch sequence down to a single commit.

Thank you for the support on getting this merged!


Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About