develooper Front page | perl.perl5.porters | Postings from January 2020

Re: Merging smoke-me/test_hv_macro

Thread Previous | Thread Next
From:
demerphq
Date:
January 23, 2020 15:03
Subject:
Re: Merging smoke-me/test_hv_macro
Message ID:
CANgJU+VrJ4VL0-Obg_PuRr-Xd_O7qr6fYBWULz+M5KrmHg19Ow@mail.gmail.com
Ok. Well I'll work the problems I understand and will hope some steps up to
help with the rest.

My guess is that I'm not handling 32 bit builds right in some way that
isn't clear so far from the output. That was one of the more difficult
aspects of this set of tests.

Yves

On Thu, 23 Jan 2020, 22:56 James E Keenan, <jkeenan@pobox.com> wrote:

> On 1/23/20 9:36 AM, James E Keenan wrote:
> > On 1/23/20 9:15 AM, demerphq wrote:
> >>
> >>
> >> On Thu, 23 Jan 2020, 21:52 James E Keenan, <jkeenan@pobox.com
> >> <mailto:jkeenan@pobox.com>> wrote:
> >>
> >>     On 1/23/20 4:44 AM, Tony Cook wrote:
> >>      > On Thu, Jan 23, 2020 at 08:49:32AM +0100, demerphq wrote:
> >>      >> Hi All,
> >>      >>
> >>      >> In #17244 we discovered there were no tests for the internals
> >> of the
> >>      >> hashing code. Following that I created smoke-me/test_hv_macro,
> >>     which I
> >>      >> think is a reasonable set of tests to start with. Its been out
> >> there
> >>      >> for a while, but I havent seen any smoke reports.
> >>      >
> >>      > http://perl.develop-help.com/?b=smoke-me%2Ftest_hv_macro
> >>      >
> >>      > There's a few smokes, none of the failures seem related.
> >>      >
> >>
> >>     I've rebased smoke-me/test_hv_macro, corrected one typo and
> >>     re-pushed it
> >>     to origin so that I can smoke it on some BSD machines previously
> >>     overlooked.
> >>
> >>     If the results are satisfactory and there are no other objections,
> >> I'll
> >>     merge it to blead tomorrow.
> >>
> >>
> >> Sweet! Thank you so much. Much obliged to you for that.
> >>
> >> Yves
> >>
> >
> > While I have pushed the rebased smoke-me/test_hv_macro branch to origin,
> > in the course of testing it I noticed that a new build-time warning has
> > been introduced:
> >
> > #####
> > cc -c   -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong
> > -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
> > -Wno-deprecated-declarations -Wall -Werror=pointer-arith -Wextra
> > -Wc++-compat -Wwrite-strings -Werror=declaration-after-statement -O2
> > -DVERSION=\"1.07\" -DXS_VERSION=\"1.07\" -fPIC "-I../.."   APItest.c
> > In file included from ../../perl.h:5471:0,
> >                   from APItest.xs:10:
> > APItest.c: In function ‘XS_XS__APItest__HvMacro_u8_to_u16_le’:
> > ../../pp.h:419:25: warning: ‘RETVAL’ may be used uninitialized in this
> > function [-Wmaybe-uninitialized]
> >               & (TARGu_uv <=
> (UV)IV_MAX)))                                \
> >                           ^~
> > APItest.c:13153:5: note: ‘RETVAL’ was declared here
> >    UV RETVAL;
> >       ^~~~~~
> > cc -c   -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong
> > -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
> > -Wno-deprecated-declarations -Wall -Werror=pointer-arith -Wextra
> > -Wc++-compat -Wwrite-strings -Werror=declaration-after-statement -O2
> > -DVERSION=\"1.07\" -DXS_VERSION=\"1.07\" -fPIC "-I../.."
> > XSUB-undef-XS_VERSION.c
> > #####
> >
> > Could this be fixed before we merge to blead?
> >
> > Thank you very much.
> > Jim Keenan
>
> Unfortunately, this branch experienced a build-time failure on one of
> those continuous-integration thingees we've added in recent months.
> Worse, the build-time failure was on one Windows machine (but apparently
> not the other).
>
> The failure is reported here:
> https://github.com/Perl/perl5/runs/405217819
>
> And the full log is here:
>
> https://pipelines.actions.githubusercontent.com/F8yobFedDMKReLD2lUI49NJpt8TNtEKo3DptPtnjfqw2qokl1r/_apis/pipelines/1/runs/3329/signedlogcontent/3?urlExpires=2020-01-23T14%3A52%3A44.0698951Z&urlSigningMethod=HMACV1&urlSignature=HRgQOFbDXP9O9kiPF%2BZz6WrTFcIBG2t8yI9370k1x2M%3D
>
> Here is the relevant tail of the log:
>
> #####
> 2020-01-23T14:38:26.7196851Z Generating a nmake-style Makefile
> 2020-01-23T14:38:26.7197220Z Writing Makefile for XS::APItest
> 2020-01-23T14:38:27.3263530Z Running Mkbootstrap for APItest ()
> 2020-01-23T14:38:27.3455938Z Writing APItest.bs
> 2020-01-23T14:38:27.3624038Z    D:\a\perl5\perl5\miniperl.exe
> "-I..\..\lib" -MExtUtils::Command -e chmod -- 644 "APItest.bs"
> 2020-01-23T14:38:27.4098671Z    D:\a\perl5\perl5\miniperl.exe
> "-I..\..\lib" -MExtUtils::Command::MM -e cp_nonempty -- APItest.bs
> ..\..\lib\auto\XS\APItest\APItest.bs 644
> 2020-01-23T14:38:27.4567415Z    "..\..\miniperl.exe" "-I..\..\lib"
> "..\..\lib\ExtUtils\xsubpp"  -typemap
> D:\a\perl5\perl5\lib\ExtUtils\typemap -typemap
> D:\a\perl5\perl5\ext\XS-APItest\typemap  APItest.xs > APItest.xsc
> 2020-01-23T14:38:28.0768402Z    D:\a\perl5\perl5\miniperl.exe
> "-I..\..\lib" -MExtUtils::Command -e mv -- APItest.xsc APItest.c
> 2020-01-23T14:38:28.1207595Z    cl -c    -nologo -GF -W3 -MD -DWIN32
> -D_CONSOLE -DNO_STRICT -DWIN64 -D_CRT_SECURE_NO_DEPRECATE
> -D_CRT_NONSTDC_NO_DEPRECATE -D_WINSOCK_DEPRECATED_NO_WARNINGS
> -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -O1
> -Zi -GL -fp:precise    -DVERSION=\"1.07\"  -DXS_VERSION=\"1.07\"
> "-I..\..\lib\CORE"   -FdAPItest.pdb APItest.c
> 2020-01-23T14:38:28.1309961Z APItest.c
> 2020-01-23T14:38:28.3417297Z d:\a\perl5\perl5\lib\CORE\inline.h(2138):
> warning C4244: '=': conversion from '__int64' to 'I32', possible loss of
> data
> 2020-01-23T14:38:28.3424724Z d:\a\perl5\perl5\lib\CORE\inline.h(2213):
> warning C4244: '=': conversion from '__int64' to 'I32', possible loss of
> data
> 2020-01-23T14:38:28.3428413Z d:\a\perl5\perl5\lib\CORE\inline.h(2257):
> warning C4244: '=': conversion from '__int64' to 'I32', possible loss of
> data
> 2020-01-23T14:38:28.3533931Z APItest.xs(1352): warning C4267: 'return':
> conversion from 'size_t' to 'I32', possible loss of data
> 2020-01-23T14:38:28.3653029Z APItest.xs(1945): warning C4244: '=':
> conversion from 'IV' to 'int', possible loss of data
> 2020-01-23T14:38:28.3654586Z APItest.xs(1949): warning C4244: '=':
> conversion from 'UV' to 'U32', possible loss of data
> 2020-01-23T14:38:28.3664889Z APItest.xs(2001): warning C4267:
> 'function': conversion from 'size_t' to 'I32', possible loss of data
> 2020-01-23T14:38:28.3901318Z APItest.xs(2657): warning C4267:
> 'function': conversion from 'size_t' to 'I32', possible loss of data
> 2020-01-23T14:38:28.3994912Z APItest.xs(3090): warning C4244: '=':
> conversion from 'IV' to 'I32', possible loss of data
> 2020-01-23T14:38:28.4189383Z APItest.xs(4161): warning C4244: '=':
> conversion from '__int64' to 'I32', possible loss of data
> 2020-01-23T14:38:28.4246049Z APItest.xs(4366): warning C4244:
> 'function': conversion from 'UV' to 'U32', possible loss of data
> 2020-01-23T14:38:28.4262972Z APItest.xs(4475): warning C4244:
> 'function': conversion from 'UV' to 'I32', possible loss of data
> 2020-01-23T14:38:28.5146306Z APItest.xs(6794): warning C4244:
> 'function': conversion from 'IV' to 'const int', possible loss of data
> 2020-01-23T14:38:28.5192137Z APItest.xs(7123): error C2057: expected
> constant expression
> 2020-01-23T14:38:28.5268820Z APItest.xs(7123): error C2466: cannot
> allocate an array of constant size 0
> 2020-01-23T14:38:28.5271337Z APItest.xs(7123): error C2133: 'in':
> unknown size
> 2020-01-23T14:38:28.5283035Z APItest.xs(7307): error C2057: expected
> constant expression
> 2020-01-23T14:38:28.5283459Z APItest.xs(7307): error C2466: cannot
> allocate an array of constant size 0
> 2020-01-23T14:38:28.5284499Z APItest.xs(7307): error C2133: 'in':
> unknown size
> 2020-01-23T14:38:28.5435974Z NMAKE : fatal error U1077: '"C:\Program
> Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\VC\Tools\MSVC\14.24.28314\bin\HostX64\x64\cl.EXE"'
> : return code '0x2'
> 2020-01-23T14:38:28.5436236Z Stop.
> 2020-01-23T14:38:28.6253981Z    cl -c    -nologo -GF -W3 -MD -DWIN32
> -D_CONSOLE -DNO_STRICT -DWIN64 -D_CRT_SECURE_NO_DEPRECATE
> -D_CRT_NONSTDC_NO_DEPRECATE -D_WINSOCK_DEPRECATED_NO_WARNINGS
> -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -O1
> -Zi -GL -fp:precise    -DVERSION=\"1.07\"  -DXS_VERSION=\"1.07\"
> "-I..\..\lib\CORE"   -FdAPItest.pdb APItest.c
> 2020-01-23T14:38:28.6355448Z APItest.c
> 2020-01-23T14:38:28.8475263Z d:\a\perl5\perl5\lib\CORE\inline.h(2138):
> warning C4244: '=': conversion from '__int64' to 'I32', possible loss of
> data
> 2020-01-23T14:38:28.8480807Z d:\a\perl5\perl5\lib\CORE\inline.h(2213):
> warning C4244: '=': conversion from '__int64' to 'I32', possible loss of
> data
> 2020-01-23T14:38:28.8484137Z d:\a\perl5\perl5\lib\CORE\inline.h(2257):
> warning C4244: '=': conversion from '__int64' to 'I32', possible loss of
> data
> 2020-01-23T14:38:28.8599679Z APItest.xs(1352): warning C4267: 'return':
> conversion from 'size_t' to 'I32', possible loss of data
> 2020-01-23T14:38:28.8716333Z APItest.xs(1945): warning C4244: '=':
> conversion from 'IV' to 'int', possible loss of data
> 2020-01-23T14:38:28.8717983Z APItest.xs(1949): warning C4244: '=':
> conversion from 'UV' to 'U32', possible loss of data
> 2020-01-23T14:38:28.8728326Z APItest.xs(2001): warning C4267:
> 'function': conversion from 'size_t' to 'I32', possible loss of data
> 2020-01-23T14:38:28.8856596Z APItest.xs(2657): warning C4267:
> 'function': conversion from 'size_t' to 'I32', possible loss of data
> 2020-01-23T14:38:28.8955290Z APItest.xs(3090): warning C4244: '=':
> conversion from 'IV' to 'I32', possible loss of data
> 2020-01-23T14:38:28.9146621Z APItest.xs(4161): warning C4244: '=':
> conversion from '__int64' to 'I32', possible loss of data
> 2020-01-23T14:38:28.9202512Z APItest.xs(4366): warning C4244:
> 'function': conversion from 'UV' to 'U32', possible loss of data
> 2020-01-23T14:38:28.9221619Z APItest.xs(4475): warning C4244:
> 'function': conversion from 'UV' to 'I32', possible loss of data
> 2020-01-23T14:38:29.0064841Z APItest.xs(6794): warning C4244:
> 'function': conversion from 'IV' to 'const int', possible loss of data
> 2020-01-23T14:38:29.0108452Z APItest.xs(7123): error C2057: expected
> constant expression
> 2020-01-23T14:38:29.0108969Z APItest.xs(7123): error C2466: cannot
> allocate an array of constant size 0
> 2020-01-23T14:38:29.0109800Z APItest.xs(7123): error C2133: 'in':
> unknown size
> 2020-01-23T14:38:29.0124818Z APItest.xs(7307): error C2057: expected
> constant expression
> 2020-01-23T14:38:29.0125388Z APItest.xs(7307): error C2466: cannot
> allocate an array of constant size 0
> 2020-01-23T14:38:29.0125930Z APItest.xs(7307): error C2133: 'in':
> unknown size
> 2020-01-23T14:38:29.0261101Z NMAKE : fatal error U1077: '"C:\Program
> Files (x86)\Microsoft Visual
> Studio\2019\Enterprise\VC\Tools\MSVC\14.24.28314\bin\HostX64\x64\cl.EXE"'
> : return code '0x2'
> 2020-01-23T14:38:29.0261470Z Stop.
> 2020-01-23T14:38:29.0271581Z Unsuccessful make(ext/XS-APItest): code=512
> at ..\make_ext.pl line 587.
> 2020-01-23T14:38:29.0296561Z NMAKE : fatal error U1077:
> '..\miniperl.exe' : return code '0x2'
> 2020-01-23T14:38:29.0296935Z Stop.
> 2020-01-23T14:38:29.0337198Z ##[error]Process completed with exit code 2.
> 2020-01-23T14:38:29.0368389Z Cleaning up orphan processes
> #####
>
> I have no experience with these Windows CI setups, so I can't evaluate
> the seriousness of the problem or say what to do next.
>
> Thank you very much.
> Jim Keenan
>

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About