Front page | perl.perl5.porters |
Postings from January 2020
On Thu, 23 Jan 2020, 22:37 James E Keenan, <jkeenan@pobox.com> wrote: > On 1/23/20 9:15 AM, demerphq wrote: > > > > > > On Thu, 23 Jan 2020, 21:52 James E Keenan, <jkeenan@pobox.com > > <mailto:jkeenan@pobox.com>> wrote: > > > > On 1/23/20 4:44 AM, Tony Cook wrote: > > > On Thu, Jan 23, 2020 at 08:49:32AM +0100, demerphq wrote: > > >> Hi All, > > >> > > >> In #17244 we discovered there were no tests for the internals of > the > > >> hashing code. Following that I created smoke-me/test_hv_macro, > > which I > > >> think is a reasonable set of tests to start with. Its been out > there > > >> for a while, but I havent seen any smoke reports. > > > > > > http://perl.develop-help.com/?b=smoke-me%2Ftest_hv_macro > > > > > > There's a few smokes, none of the failures seem related. > > > > > > > I've rebased smoke-me/test_hv_macro, corrected one typo and > > re-pushed it > > to origin so that I can smoke it on some BSD machines previously > > overlooked. > > > > If the results are satisfactory and there are no other objections, > I'll > > merge it to blead tomorrow. > > > > > > Sweet! Thank you so much. Much obliged to you for that. > > > > Yves > > > > While I have pushed the rebased smoke-me/test_hv_macro branch to origin, > in the course of testing it I noticed that a new build-time warning has > been introduced: > > ##### > cc -c -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong > -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 > -Wno-deprecated-declarations -Wall -Werror=pointer-arith -Wextra > -Wc++-compat -Wwrite-strings -Werror=declaration-after-statement -O2 > -DVERSION=\"1.07\" -DXS_VERSION=\"1.07\" -fPIC "-I../.." APItest.c > In file included from ../../perl.h:5471:0, > from APItest.xs:10: > APItest.c: In function ‘XS_XS__APItest__HvMacro_u8_to_u16_le’: > ../../pp.h:419:25: warning: ‘RETVAL’ may be used uninitialized in this > function [-Wmaybe-uninitialized] > & (TARGu_uv <= (UV)IV_MAX))) \ > ^~ > APItest.c:13153:5: note: ‘RETVAL’ was declared here > UV RETVAL; > ^~~~~~ > cc -c -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong > -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 > -Wno-deprecated-declarations -Wall -Werror=pointer-arith -Wextra > -Wc++-compat -Wwrite-strings -Werror=declaration-after-statement -O2 > -DVERSION=\"1.07\" -DXS_VERSION=\"1.07\" -fPIC "-I../.." > XSUB-undef-XS_VERSION.c > ##### > > Could this be fixed before we merge to blead? > I will look into it directly and report back asap. Yves >Thread Previous | Thread Next