develooper Front page | perl.perl5.porters | Postings from September 2019

[perl #133981] ext/XS-APItest/t/locale.t crashes on Windows afterpassing a couple tests

Thread Previous | Thread Next
From:
Tony Cook via RT
Date:
September 5, 2019 05:40
Subject:
[perl #133981] ext/XS-APItest/t/locale.t crashes on Windows afterpassing a couple tests
Message ID:
rt-4.0.24-20410-1567661991-1967.133981-15-0@perl.org
On Tue, 03 Sep 2019 00:48:47 -0700, shay wrote:
> On Mon, 02 Sep 2019 18:03:28 -0700, tonyc wrote:
> > On Sun, 18 Aug 2019 04:04:52 -0700, shay wrote:
> > > On Thu, 15 Aug 2019 at 08:05, Steve Hay via RT
> > > <perlbug-followup@perl.org> wrote:
> > > >
> > > > On Mon, 12 Aug 2019 22:49:19 -0700, tonyc wrote:
> > > > > On Sat, 10 Aug 2019 05:53:14 -0700, shay wrote:
> > > > > > The patch looks good to me, except that the second
> > > > > >
> > > > > > S_wrap_wsetlocale(aTHX_ category, locale);
> > > > > >
> > > > > > looks like it should be
> > > > > >
> > > > > > S_wrap_wsetlocale(aTHX_ categories[i], result);
> > > > > >
> > > > > > ?
> > > > >
> > > > > Updated patch attached.
> > > > >
> > > >
> > > > You've changed category to categories[i], but not locale to
> > > > result.
> > > >
> > >
> > > I've retested the updated patch with that extra change that you
> > > missed
> > > too, and it is still passing all tests.
> >
> > Thanks, I've applied it with that other fix and a shiny commit
> > message
> > as 6c3320363f6cd734c66a25852aac87e4f2538215.
> >
> 
> Your commit isn't quite what I was expecting. When I noted previously
> that "You've changed category to categories[i], but not locale to
> result" I meant that the second S_wrap_wsetlocale() call should be
> S_wrap_wsetlocale(aTHX_ categories[i], result) -- to match the
> arguments of the existing second setlocale() call, which was
> setlocale(categories[i], result).
> 
> Instead, you've left that S_wrap_wsetlocale() as
> S_wrap_wsetlocale(aTHX_ categories[i], locale) and changed the
> existing setlocale() call to setlocale(categories[i], locale). Did you
> mean to do that?

Yeah, it was a dumb mistake on my part.

The attached should fix it.

Tony

---
via perlbug:  queue: perl5 status: pending release
https://rt.perl.org/Ticket/Display.html?id=133981

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About