develooper Front page | perl.perl5.porters | Postings from September 2019

[perl #132782] Missing SvPV* utf8/byte nomg macro variants

Thread Previous | Thread Next
From:
Tony Cook via RT
Date:
September 2, 2019 05:22
Subject:
[perl #132782] Missing SvPV* utf8/byte nomg macro variants
Message ID:
rt-4.0.24-5411-1567401764-230.132782-15-0@perl.org
On Fri, 30 Aug 2019 05:00:52 -0700, pali@cpan.org wrote:
> On Tuesday 06 August 2019 11:03:47 pali@cpan.org wrote:
> > On Monday 22 July 2019 15:53:30 pali@cpan.org wrote:
> > > On Tuesday 21 May 2019 10:17:47 Tony Cook wrote:
> > > > The only two problems:
> > > >
> > > > 1) The TODO tests need to be disarmed.
> > > >
> > > > op/bop.t
> > > > (Wstat: 0 Tests: 514 Failed: 0)
> > > >   TODO passed:   141, 143, 146, 148
> > > > Files=2656, Tests=1220001, 815 wallclock secs (318.43 usr 18.79
> > > > sys + 2117.74 cusr 78.50 csys = 2533.46 CPU)
> > > > Result: PASS
> > > >
> > > > You've added the TODO tests after the fixes, you could either
> > > > remove
> > > > the TODO sets entirely, or move the test commit before the doop.c
> > > > changes and disarm the TODO sets in the doop.c commit (or a later
> > > > commit.)
> > >
> > > I removed TODO marks in this test.
> > >
> > > > 2) The other problem is there's still no API tests, as I said in
> > > > https://rt.perl.org/Ticket/Display.html?id=132782#txn-1619990
> > > >
> > > > There's no tests for the new APIs (which can go in ext/XS-
> > > > APItest/)
> > >
> > > I added XS-API tests for SvPVutf8_nomg and SvPVbyte_nomg.
> > >
> > > Please look at updated V7 patches.
> >
> > Hi Tony! It is now OK? Or is something more needed for these patches?
> 
> Tony: ping

Thanks, applied as 423ce6234bb755185e783187da2b1fc06560ce8b through 3e13e8f6968d020943ce324057a81959fc9c5631.

Sorry about the lack of follow-up, I forgot to bookmark this ticket and lost track of it otherwise.

Tony


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=132782

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About