develooper Front page | perl.perl5.porters | Postings from August 2019

[perl #133981] ext/XS-APItest/t/locale.t crashes on Windows afterpassing a couple tests

Thread Previous
From:
Steve Hay via RT
Date:
August 10, 2019 12:54
Subject:
[perl #133981] ext/XS-APItest/t/locale.t crashes on Windows afterpassing a couple tests
Message ID:
rt-4.0.24-14439-1565441594-699.133981-15-0@perl.org
On Wed, 24 Jul 2019 00:14:12 -0700, shay wrote:
> On Tue, 23 Jul 2019 22:59:04 -0700, tonyc wrote:
> > On Tue, 23 Jul 2019 17:12:25 -0700, tonyc wrote:
> > > On Tue, 23 Jul 2019 04:54:07 -0700, tonyc wrote:
> > > > On Tue, 23 Jul 2019 04:09:07 -0700, tonyc wrote:
> > > > > On Tue, 23 Jul 2019 00:07:47 -0700, shay wrote:
> > > > > > On Mon, 22 Jul 2019 23:29:59 -0700, tonyc wrote:
> > > > > > > This is a bug report for perl from tony@develop-help.com,
> > > > > > > generated with the help of perlbug 1.41 running under perl
> > > > > > > 5.31.3.
> > > > > > >
> > > > > > >
> > > > > > > -----------------------------------------------------------------
> > > > > > > [Please describe your issue here]
> > > > > > >
> > > > > > > While testing perl on Windows 10 x64 I saw ext/XS-
> > > > > > > APItest/t/locale.t
> > > > > > > failing.
> > > > > > >
> > > > > >
> > > > > > This is a duplicate of
> > > > > > https://rt.perl.org/Ticket/Display.html?id=133981, which is
> > > > > > documented
> > > > > > in README.win32:
> > > > > > https://perl5.git.perl.org/perl.git/commit/7115365105
> > > > >
> > > > > Oops, I've merged them.
> > > > >
> > > > > > You've debugged it further than me though :-)
> > > > > >
> > > > > > Do you have the May 2019 Update on your machine?
> > > > >
> > > > > I don't think I'd used it since I set up this machine in
> > > > > February.
> > > > >
> > > > > I'm updating now, though that might require a reboot.
> > > >
> > > > Found a chance to reboot.
> > >
> > > It turns out I misunderstood the question - I'm running version
> > > 1803
> > > of Windows 10.
> > >
> > > I'm on the "Semi-Annual Channel" rather than the oh so clearly
> > > named
> > > "Semi-Annual Channel (Targeted)".
> > >
> > > So I still have the buggy crt, I'm not sure this is worth us
> > > fixing.
> >
> > A reply didn't make it to the ticket:
> >
> > https://www.nntp.perl.org/group/perl.perl5.porters/2019/07/msg255688.html
> >
> > indicating that 1903 didn't fix it.
> >
> 
> They did change something, though - see my comment here:
> https://rt.perl.org/Ticket/Display.html?id=133981#txn-1645106. Maybe
> there are two separate issues here - one CRT problem which they have
> fixed (khw's shay.c program now behaves correctly), and one other CRT
> problem which your patch works around. We should probably tell them
> about that too and hopefully they'll fix it in some future update
> (though we still need the workaround for now, of course).
> 
> Thanks for the patch. I'll give it a try with some different
> compiler/OS versions.

The patch looks good to me, except that the second

S_wrap_wsetlocale(aTHX_ category, locale);

looks like it should be

S_wrap_wsetlocale(aTHX_ categories[i], result);

?

Regardless, it fixes the failures on Windows 10, using VC14, 14.1 and 14.2. I've also tried VC12 on Win10 and all is OK.

On Windows 7 I've tried VC7 and VC14 and all is well.

(I wouldn't worry about the invalid parameter warnings coming out, at least not now, because they're probably not new and there are many other invalid parameter warnings when running the full test suite in a DebugFull build, and always have been ever since that build option was added.)


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=133981

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About