develooper Front page | perl.perl5.porters | Postings from July 2019

[perl #134172] commit 027471cf breaks t/op/sprintf2.t on FreeBSD-11

Thread Next
From:
Hugo van der Sanden via RT
Date:
July 25, 2019 14:17
Subject:
[perl #134172] commit 027471cf breaks t/op/sprintf2.t on FreeBSD-11
Message ID:
rt-4.0.24-14001-1564064270-1864.134172-15-0@perl.org
On Wed, 24 Jul 2019 17:38:13 -0700, tonyc wrote:
> It looks reasonable to me.

Thanks.

> One thing I noticed in the original code was that
> STORE_LC_NUMERIC_SET_TO_NEEDED() could call the possibly expensive
> IN_LC(LC_NUMERIC) up to three times:
> 
> +                    (   (  in_lc_numeric &&
> _NOT_IN_NUMERIC_UNDERLYING)     \
> +                     || (! in_lc_numeric &&
> _NOT_IN_NUMERIC_STANDARD)));    \
> +            if (in_lc_numeric) {
> \
> 
> (for a bare STORE_LC_NUMERIC_SET_TO_NEEDED() in_lc_numeric is
> IN_LC(LC_NUMERIC) )

Yes, I addressed the same in my second patch, in a slightly different manner.

Hugo

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=134172

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About