develooper Front page | perl.perl5.porters | Postings from July 2019

[perl #134172] commit 027471cf breaks t/op/sprintf2.t on FreeBSD-11

Thread Previous | Thread Next
From:
James E Keenan via RT
Date:
July 24, 2019 21:18
Subject:
[perl #134172] commit 027471cf breaks t/op/sprintf2.t on FreeBSD-11
Message ID:
rt-4.0.24-6018-1564003081-1189.134172-15-0@perl.org
On Mon, 22 Jul 2019 20:06:30 GMT, jkeenan wrote:
> On Mon, 22 Jul 2019 18:14:11 GMT, hv wrote:
> > On Mon, 22 Jul 2019 09:15:20 -0700, jkeenan wrote:
> > > On Mon, 22 Jul 2019 16:11:13 GMT, hv wrote:
> > > > On Mon, 22 Jul 2019 08:47:39 -0700, hv wrote:
> > > > > As Dave mentioned, the expensive part is the hints check of
> > > > > IN_LC(LC_NUMERIC);
> > > > > I cache a copy of that for sv_vcatpvfn_flags (and format_hexfp)
> > > > > to
> > > > > use;
> > > > > however I note that the same check is done multiple times within
> > > > > the
> > > > > underlying STORE_LC_NUMERIC_SET_TO_NEEDED macro, so it may be
> > > > > worth
> > > > > making variants of WITH_LC_x and STORE_LC_x that accept a cached
> > > > > boolean
> > > > > for the hints check.
> > > >
> > > > Something like the attached (not extensively tested).
> > >
> > > Hugo, I created this smoke branch just now after seeing our *first*
> > > patch:
> > >
> > > smoke-me/jkeenan/hv/134172-sprintf
> > >
> > > Should this second patch be applied to that branch as well?
> > 
> > Up to you: I'd like a second opinion on it, particularly about the
> > naming of the additional macros, but I think it's reasonably likely to
> > work. (It passed tests here on a build with -DNO_THREAD_SAFE_LOCALE,
> > but I haven't tried any other variations.)
> > 
> > Hugo
> 
> Applying to branch for smoke testing.

Smoke-test results in the branch appear satisfactory.

http://perl.develop-help.com/?b=smoke-me%2Fjkeenan%2Fhv%2F134172-sprintf

What else do we have to decide before merging this branch and closing this ticket?

Thank you very much.
-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=134172

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About