On Tuesday 21 May 2019 10:17:47 Tony Cook wrote: > The only two problems: > > 1) The TODO tests need to be disarmed. > > op/bop.t (Wstat: 0 Tests: 514 Failed: 0) > TODO passed: 141, 143, 146, 148 > Files=2656, Tests=1220001, 815 wallclock secs (318.43 usr 18.79 sys + 2117.74 cusr 78.50 csys = 2533.46 CPU) > Result: PASS > > You've added the TODO tests after the fixes, you could either remove > the TODO sets entirely, or move the test commit before the doop.c > changes and disarm the TODO sets in the doop.c commit (or a later > commit.) I removed TODO marks in this test. > 2) The other problem is there's still no API tests, as I said in > https://rt.perl.org/Ticket/Display.html?id=132782#txn-1619990 > > There's no tests for the new APIs (which can go in ext/XS-APItest/) I added XS-API tests for SvPVutf8_nomg and SvPVbyte_nomg. Please look at updated V7 patches.Thread Previous | Thread Next