[perl #134218] dtrace build of perl-5.30.0 uses undefined $(ECHO)

On Thu, 27 Jun 2019 11:15:59 -0700, enchanter wrote:
> In regard to: [perl #134218] dtrace build of perl-5.30.0 uses
> undefined...:
> 
> > On Fri, 21 Jun 2019 13:56:11 -0700, enchanter wrote:
> >>
> >> FreeBSD uses the other branch of the ||, based on my reading of the
> >> comments in the 5.26.2 delta, so I'm moderately certain it's only
> >> Solaris
> >> and Solaris-like systems that are going to trigger the code path
> >> that
> >> wants $(ECHO).
> >>
> >> If you visually inspect Makefile.SH , though, you'll see that it's
> >> used
> >> without ever being defined earlier.
> >
> > That change was originally made for FreeBSD where make appears to
> > predefine ECHO to echo, so the code worked.
> >
> > The attached should fix this for Solaris-ish makes.
> 
> My patch (which I had not submitted yet) is basically the same, except
> I used
> 
> ECHO = $echo
> 
> since config.sh is guaranteed to have $echo set for the system.
> 
> Yours will work fine, and will certainly address the issue for
> Solaris-ish
> systems.

Applied with ECHO = $echo as c0ad3f089909eceaf6d442a6805e5b46d1fee0e0.

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=134218

• [perl #134218] dtrace build of perl-5.30.0 uses undefined $(ECHO) by Tony Cook via RT