develooper Front page | perl.perl5.porters | Postings from June 2019

Re: [perl #134218] dtrace build of perl-5.30.0 uses undefined$(ECHO)

Thread Next
From:
Tim Mooney
Date:
June 27, 2019 18:15
Subject:
Re: [perl #134218] dtrace build of perl-5.30.0 uses undefined$(ECHO)
Message ID:
alpine.SOC.2.20.1906271312330.25262@dogbert.cc.ndsu.NoDak.edu
In regard to: [perl #134218] dtrace build of perl-5.30.0 uses undefined...:

> On Fri, 21 Jun 2019 13:56:11 -0700, enchanter wrote:
>>
>> FreeBSD uses the other branch of the ||, based on my reading of the
>> comments in the 5.26.2 delta, so I'm moderately certain it's only
>> Solaris
>> and Solaris-like systems that are going to trigger the code path that
>> wants $(ECHO).
>>
>> If you visually inspect Makefile.SH , though, you'll see that it's
>> used
>> without ever being defined earlier.
>
> That change was originally made for FreeBSD where make appears to predefine ECHO to echo, so the code worked.
>
> The attached should fix this for Solaris-ish makes.

My patch (which I had not submitted yet) is basically the same, except
I used

ECHO = $echo

since config.sh is guaranteed to have $echo set for the system.

Yours will work fine, and will certainly address the issue for Solaris-ish
systems.

Thanks!

Tim
-- 
Tim Mooney                                             Tim.Mooney@ndsu.edu
Enterprise Computing & Infrastructure                  701-231-1076 (Voice)
Room 242-J6, Quentin Burdick Building                  701-231-8541 (Fax)
North Dakota State University, Fargo, ND 58105-5164

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About