develooper Front page | perl.perl5.porters | Postings from June 2019

[perl #134218] dtrace build of perl-5.30.0 uses undefined $(ECHO)

Thread Previous | Thread Next
From:
James E Keenan via RT
Date:
June 22, 2019 01:55
Subject:
[perl #134218] dtrace build of perl-5.30.0 uses undefined $(ECHO)
Message ID:
rt-4.0.24-28930-1561168516-815.134218-15-0@perl.org
On Fri, 21 Jun 2019 20:56:11 GMT, enchanter wrote:
> In regard to: [perl #134218] dtrace build of perl-5.30.0 uses
> undefined...:
> 
> > On Fri, 21 Jun 2019 19:55:57 GMT, enchanter wrote:
> >>
> >> This is a bug report for perl from tim.mooney@ndsu.edu,
> >> generated with the help of perlbug 1.40 running under perl 5.22.4.
> >>
> >>
> >> -----------------------------------------------------------------
> >> [Please describe your issue here]
> >>
[snip]
> >>
> >
> > Can you supply the full ./Configure command you used to configure
> > this perl?
> 
> /export/home/mooney/oi-userland/components/perl/perl-530/perl-
> 5.30.0/Configure -de -Dmksymlinks -Ulocincpth= -Uloclibpth=
> -Dbin=/usr/perl5/5.30/bin -Dcc="/usr/gcc/6/bin/gcc -m64"
> -Dcf_email="oi-dev@openindiana.org" -Dcf_by="perl-bugs"
> -Dlibperl=libperl.so -Dmyhostname="localhost" -Dprefix=/usr/perl5/5.30
> -Dprivlib=/usr/perl5/5.30/lib -Dsitelib=/usr/perl5/site_perl/5.30
> -Dsiteprefix=/usr/perl5/5.30 -Dvendorlib=/usr/perl5/vendor_perl/5.30
> -Dvendorprefix=/usr/perl5/5.30 -Duse64bitall -Duseshrplib -Dusedtrace
> -Dusethreads -Dlibpth="/lib/64 /usr/lib/64")
> 
> 
> I'm actually building 5.30.0 using the same recipe that the packaged
> perl
> for OI uses, just updated for 5.30.0.  It's part of 'oi-userland', and
> you can find the whole thing here:
> 
> https://github.com/OpenIndiana/oi-userland
> 
> and the older perl-522 and perl-524 packages are generated using the
> Makefiles in here:
> 
> https://github.com/OpenIndiana/oi-
> userland/tree/oi/hipster/components/perl/perl-522
> https://github.com/OpenIndiana/oi-
> userland/tree/oi/hipster/components/perl/perl-524
> 
[snip]
> >>
> >> The fix is straightforward.  In Makefile.SH, in the section where
> >> other
> >> settings like CC, LD, CPS, RMS, etc. are set, we just need a
> >>
> >> ECHO = $echo
> >>
> >> $echo *is* being set by Configure and added to config.sh, it's just
> >> that
> >> Makefile.SH and hence Makefile are using $(ECHO) in one and only one
> >> place: the dtrace probes.
> >>
> >> If you agree this is the right fix, I can submit the trivial patch
> >> to
> >> fix it.
> >>
[snip]

> > I don't have any Solaris available -- we could really use some smoke-
> > testers on those systems -- but I do have FreeBSD with dtrace.
> 
> FreeBSD uses the other branch of the ||, based on my reading of the
> comments in the 5.26.2 delta, so I'm moderately certain it's only
> Solaris
> and Solaris-like systems that are going to trigger the code path that
> wants $(ECHO).
> 
> If you visually inspect Makefile.SH , though, you'll see that it's
> used
> without ever being defined earlier.
> 

If you can supply a patch (as attachment), preferably drawn against perl 5 blead (HEAD of git checkout), we'll have it evaluated by people who know more about these things than I do.

Thank you very much.

-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=134218

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About