develooper Front page | perl.perl5.porters | Postings from June 2019

[perl #134164] Clarify documentation for bisection

Thread Next
From:
James E Keenan via RT
Date:
June 4, 2019 00:54
Subject:
[perl #134164] Clarify documentation for bisection
Message ID:
rt-4.0.24-25224-1559609672-577.134164-15-0@perl.org
On Tue, 04 Jun 2019 00:20:10 GMT, tonyc wrote:
> On Sat, 01 Jun 2019 18:33:12 -0700, jkeenan@pobox.com wrote:
> > Some dialog from irc.perl.org #p5p this evening:
> >
> > #####
> > (08:09:00 PM) hydahy: Anyone familiar with Porting/bisect.pl bailing
> > out
> > early in Configure with the error "./Configure: 1: ./posthint.sh: Bad
> > substitution" ?
> > ...
> > (09:10:34 PM) kid51: What is the command you provided for bisection?
> > ...
> > (09:17:15 PM) hydahy: Started with: ./Porting/bisect.pl --target
> > t/io/pipe.t --start v5.31.0 -A -Alibpth="/system/lib /vendor/lib"
> > (09:17:31 PM) hydahy: Error also occurs with ./Porting/bisect.pl
> > --test-build -A -Alibpth="/system/lib /vendor/lib"
> > (09:21:38 PM) kid51: Remove the first '-A' and start over.
> > (09:23:14 PM) hydahy: ohhhh, I misunderstood the POD then
> > (09:23:26 PM) kid51: You're not the first!
> > (09:23:34 PM) khw: clarifying patches welcome
> > #####
> >
> > hydahy is not the first, because I know I have had to pose this
> > question
> > at least twice before.
> >
> > TonyC and other frequent bisectors, please review patch attached.
> 
> --D I<config_arg=value>
> +-DI<config_arg=value>
> 
> =item *
> 
> --U I<config_arg>
> +-UI<config_arg>
> 
> =item *
> 
> --A I<config_arg=value>
> +-AI<config_arg=value>
> 
> bisect.pl accepts the switches both with and without the space, just
> as Configure does which is what it looks like you're changing here.
> 
> For example, I ran:
> 
> perl ../bisect.pl --start=v5.26.0 -D prefix=/home/tony/perl/bisect -e
> 'my $a := 2'
> 
> and in the resulting config.sh:
> 
> config_args='-dEs -Dcc=ccache cc -Dld=cc -Dlibpth=/lib/x86_64-linux-
> gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
> /usr/lib /usr/local/lib64 /lib64 /usr/lib64 -Doptimize=-g
> -Dprefix=/home/tony/perl/bisect -Dusedevel'
> 
> The I<config_arg> in the documentation might be ambiguous if you're
> not familiar with Configure (ie. that it accepts -A, -D and -U
> switches), but your patch doesn't change that (config_name instead,
> maybe?)
> 
> I suspect the best change would be to include your commit message:
> 
> The -D, -A and -U switches should be spelled as if you were normally
> giving them to ./Configure.
> 
> which would resolve the ambiguity.
> 
> I don't think the following is needed:
> 
> -    -Dnoextensions=Encode
> -    -Uusedevel
> +    -Dnoextensions=Encode \
> +    -Uusedevel \
>      -Accflags=-DNO_MATHOMS
> 
> as those are intended as separate examples.
> 
> Tony

Thanks.  Pushed to blead in commit 6aed8e2d2d20b43fbdcd898f56cd758774b15195.

-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=134164

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About