develooper Front page | perl.perl5.porters | Postings from June 2019

[perl #134164] Clarify documentation for bisection

Thread Previous | Thread Next
Tony Cook via RT
June 4, 2019 00:20
[perl #134164] Clarify documentation for bisection
Message ID:
On Sat, 01 Jun 2019 18:33:12 -0700, wrote:
> Some dialog from #p5p this evening:
> #####
> (08:09:00 PM) hydahy: Anyone familiar with Porting/ bailing out 
> early in Configure with the error "./Configure: 1: ./ Bad 
> substitution" ?
> ...
> (09:10:34 PM) kid51: What is the command you provided for bisection?
> ...
> (09:17:15 PM) hydahy: Started with: ./Porting/ --target 
> t/io/pipe.t --start v5.31.0 -A -Alibpth="/system/lib /vendor/lib"
> (09:17:31 PM) hydahy: Error also occurs with ./Porting/ 
> --test-build -A -Alibpth="/system/lib /vendor/lib"
> (09:21:38 PM) kid51: Remove the first '-A' and start over.
> (09:23:14 PM) hydahy: ohhhh, I misunderstood the POD then
> (09:23:26 PM) kid51: You're not the first!
> (09:23:34 PM) khw: clarifying patches welcome
> #####
> hydahy is not the first, because I know I have had to pose this question 
> at least twice before.
> TonyC and other frequent bisectors, please review patch attached.

--D I<config_arg=value>
 =item *
--U I<config_arg>
 =item *
--A I<config_arg=value>
+-AI<config_arg=value> accepts the switches both with and without the space, just as Configure does which is what it looks like you're changing here.

For example, I ran:

  perl ../ --start=v5.26.0 -D prefix=/home/tony/perl/bisect -e 'my $a := 2'

and in the resulting

config_args='-dEs -Dcc=ccache cc -Dld=cc -Dlibpth=/lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /usr/lib /usr/local/lib64 /lib64 /usr/lib64 -Doptimize=-g -Dprefix=/home/tony/perl/bisect -Dusedevel'

The I<config_arg> in the documentation might be ambiguous if you're not familiar with Configure (ie. that it accepts -A, -D and -U switches), but your patch doesn't change that (config_name instead, maybe?)

I suspect the best change would be to include your commit message:

The -D, -A and -U switches should be spelled as if you were normally
giving them to ./Configure.

which would resolve the ambiguity.

I don't think the following is needed:

-    -Dnoextensions=Encode
-    -Uusedevel
+    -Dnoextensions=Encode \
+    -Uusedevel \

as those are intended as separate examples.


via perlbug:  queue: perl5 status: new

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About