develooper Front page | perl.perl5.porters | Postings from May 2019

[perl #132964] Missing newSVsv_nomg macro variant

From:
Tony Cook via RT
Date:
May 29, 2019 06:04
Subject:
[perl #132964] Missing newSVsv_nomg macro variant
Message ID:
rt-4.0.24-22756-1559109845-1392.132964-15-0@perl.org
On Tue, 14 May 2019 17:02:17 -0700, tonyc wrote:
> On Mon, 13 May 2019 17:09:09 -0700, tonyc wrote:
> > On Tue, 23 Apr 2019 06:27:36 -0700, pali@cpan.org wrote:
> > > On Tuesday 02 April 2019 11:51:28 pali@cpan.org wrote:
> > > > On Thursday 28 March 2019 17:01:47 Tony Cook via RT wrote:
> > > > > On Thu, 28 Mar 2019 05:58:25 -0700, pali@cpan.org wrote:
> > > > > > On Tuesday 26 February 2019 10:00:58 pali@cpan.org wrote:
> > > > > > > On Wednesday 13 February 2019 20:16:03 pali@cpan.org wrote:
> > > > > > > > On Tuesday 12 February 2019 20:13:42 Tony Cook via RT wrote:
> > > > > > > > > On Thu, 07 Feb 2019 05:29:14 -0800, pali@cpan.org wrote:
> > > > > > > > > > And here is patch which makes sv_mortalcopy_flags()
> > > > > > > > > > function public.
> > > > > > > > >
> > > > > > > > > +=for apidoc sv_mortalcopy_flags
> > > > > > > > > +
> > > > > > > > > +Like C<sv_mortalcopy>, but the extra C<flags> are passed
> > > > > > > > > to the
> > > > > > > > > +C<sv_setsv_flags>.
> > > > > > > > > +
> > > > > > > > >
> > > > > > > > > SV_GMAGIC is also meaningful for sv_mortalcopy_flags().
> > > > > > > >
> > > > > > > > So... any suggestion how to improve documentation?
> > > > > > >
> > > > > > > Tony, ping. What do you prefer or how do you want to improve
> > > > > > > this change?
> > > > > >
> > > > > > ping
> > > > >
> > > > > Sorry, I thought this was all resolved (and I was sort of wrong.)
> > > > >
> > > > > Since sv_mortalcopy_flags()'s treatment of S_GMAGIC is equivalent
> > > > > to sv_setsv_flags() treatment, I no longer think there's any extra
> > > > > documentation needed.
> > > > >
> > > > > I mis-read the code, sorry for my misunderstanding and the delay in
> > > > > the response.
> > > >
> > > > Ok, so are there any other changes needed for this patch?
> > > 
> > > So if not, can you apply that patch?
> > 
> > https://rt.perl.org/Ticket/Display.html?id=132964#txn-1614862
> 
> Your reply didn't make it to the ticket.
> 
> You're right, I missed a patch, I'll apply it post 5.31.

Thanks, applied as c6dcb9ed461718e37907fd4a12e9c4e267d460eb.

Sorry for the mix-up.

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=132964



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About