Front page | perl.perl5.porters |
Postings from May 2019
On Thursday 28 March 2019 13:41:30 pali@cpan.org wrote: > On Tuesday 19 March 2019 20:59:22 Tony Cook via RT wrote: > > On Tue, 19 Mar 2019 20:49:46 -0700, tonyc wrote: > > > On Tue, 19 Mar 2019 01:55:18 -0700, pali@cpan.org wrote: > > > > On Thursday 28 February 2019 15:57:17 pali@cpan.org wrote: > > > > > In attachment is V5 version of patches. There is updated > > > > > documentation for them. > > > > > > > > Tony, can you look at new patch version? > > > > > > make test fails. > > Fixed. > > > > There still aren't any vec() tests (see the attached.) > > I included that patch into v6 version. > > > > There's no tests for the new APIs (which can go in ext/XS-APItest/) > > > > > > Tony > > > > Also: > > > > - int mg_flags = SV_GMAGIC; > > + int mg_flags = 0; > > + > > + if (flags & SV_GMAGIC) > > + mg_flags = SV_GMAGIC; > > > > Can just be: > > > > int mg_flags = flags & SV_GMAGIC; > > > > but should probably be: > > > > U32 mg_flags = flags & SV_GMAGIC; > > Changed. > > New version v6 is in attachment. > > Now make test passes. There are some problems with porting/pod_rules.t > and porting/podcheck.t but I have not touched code for those files... so > looks like false-positive. Tony, can you review V6 patches?Thread Previous | Thread Next