develooper Front page | perl.perl5.porters | Postings from April 2019

Re: [perl #134058] Bleadperl v5.29.9-123-gaabfeadc64 breaksETHER/signatures-0.13.tar.gz

Thread Previous
From:
Dave Mitchell
Date:
April 24, 2019 15:38
Subject:
Re: [perl #134058] Bleadperl v5.29.9-123-gaabfeadc64 breaksETHER/signatures-0.13.tar.gz
Message ID:
20190424153759.GN6612@iabyn.com
On Mon, Apr 22, 2019 at 10:34:57AM -0700, (Andreas J. Koenig) (via RT) wrote:
> Sample fail report:
> 
> http://www.cpantesters.org/cpan/report/a0340894-64b7-11e9-a696-470fc989963f
> 
> Xref:
> 
> https://rt.cpan.org/Ticket/Display.html?id=129281

This bisects to the following. I haven't looked further yet.

commit aabfeadc64376a5e473fe2a3fed20fd0d311dca5
Author:     Karl Williamson <khw@cpan.org>
AuthorDate: Tue Mar 26 21:54:03 2019 -0600
Commit:     Karl Williamson <khw@cpan.org>
CommitDate: Sat Apr 13 16:20:35 2019 -0600

    Make a few parse fcns accessible to B::Hooks::Parser
    
    This module had made copies of three functions from toke.c many releases
    ago, and they stagnated.  Most outside code has no business calling
    them, but the least worst choice I believe is to make them accessible,
    but hide that fact.
    
    This commit makes them accessible to modules that have defined PERL_EXT.
    It does not document their API's, and marks them as subject to change,
    so they aren't even listed as available in the docs.  In other words,
    you'd have to really go digging to find out you could use them.
    
    And the API of two of the three had changed since the code was
    originally stolen.  So that "subject to change" actually has happened.
    We should feel free to change the API as needed, and B::Hooks::Parser
    will have to be updated.
    
    Thanks to Tony Cook for advising me on this area unfamiliar to me.


The tests are failing this assertion:

t/weird.t .............. perl5.29.10: toke.c:2538: S_sublex_done: Assertion `PL_lex_inwhat == OP_SUBST || PL_lex_inwhat == OP_TRANS' failed.


which is saying that if PL_lex_repl is true (we're toking a
replacement), then the op (PL_lex_inwhat) must be either OP_SUBST or
OP_TRANS)

-- 
I took leave and went to hear Mrs Turner's daughter play on the harpsicon,
but Lord, it was enough to make any man sick to hear her; yet I was forced
to commend her highly.
    -- The Diary of Samuel Pepys, 1 May 1663

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About