[perl #134032] Devel::PPPort makes incorrect suggestion for changingPerl_filter_read

On Sun, 14 Apr 2019 11:15:27 -0700, karen@froods.org wrote:
> A while ago I applied some changes to B::Hooks::Parser as suggested by
> ppport.h:
> 
> https://github.com/karenetheridge/B-Hooks-
> Parser/commit/66a934c02168048cebeb5a95d6ad3bbbe6e8f707
> 
> ..and then yesterday released as
> https://metacpan.org/release/ETHER/B-Hooks-Parser-0.20.
> 
> This failed on threaded builds:
> https://rt.cpan.org/Ticket/Display.html?id=129173

I expect the output from ppport.h is intended for callers of the perl API filter_read() rather than for code that tries to redefine it.

Calling the filter_read() macro instead of using Perl_filter_read() is good advice for callers of filter_read(), I don't think it's necessary for it to deal with the hopefully much less common case of code that tries to redefine perl API functions.

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=134032

• [perl #134032] Devel::PPPort makes incorrect suggestion for changingPerl_filter_read by Tony Cook via RT
• [perl #134032] Devel::PPPort makes incorrect suggestion for changingPerl_filter_read by Karen Etheridge via RT
• [perl #134032] Devel::PPPort makes incorrect suggestion for changingPerl_filter_read by Karl Williamson via RT