[perl #133347] BBC SREZIC/Tk-804.034.tar.gz

Dana Mon, 15 Apr 2019 20:19:20 -0700, khw reče:
> On Thu, 27 Dec 2018 01:25:03 -0800, slaven@rezic.de wrote:
> > Dana Wed, 26 Dec 2018 15:55:55 -0800, public@khwilliamson.com reče:
> > > On 12/23/18 2:41 PM, slaven@rezic.de via RT wrote:
> > > > Dana Sat, 27 Oct 2018 14:07:01 -0700, slaven@rezic.de reče:
> > > > [...]
> > > >> A cursory look at the "Out of memory" failures suggest that this
> > > >> is
> > > >> another problem than the one discussed in this ticket. Maybe a
> > > >> bisect
> > > >> would help here (and of course limits have to be set before to
> > > >> protect
> > > >> the system from memory exhaustion).
> > > >
> > > > If the deprecated (but still existing) functions in Tk's
> > > > encGlue.c
> > > > are replaced, then the Out of memory errors do not happen
> > > > anymore.
> > > > These are:
> > > > - Perl_is_uni_alpha
> > > > - Perl_is_uni_alnum
> > > > - Perl_is_uni_space
> > > > - Perl_is_uni_upper
> > > > - utf8_to_uvchr
> > > > - Perl_to_utf8_lower
> > > > - Perl_to_utf8_upper
> > > >
> > > > So it looks like changes in one or more of these functions were
> > > > causing the problems.
> > >
> > > I don't understand what you are replacing them with.
> >
> > The Perl/Tk test suite fails with Out of memory errors since perl
> > 5.29.x. This was not the case with earlier perl versions, and it is
> > not the case after the above mentioned functions are not used anymore
> > in Perl/Tk's encGlue.c. So it looks to me that there was a change in
> > one or more of the mentioned functions which is causing the problems
> > in Perl/Tk's test suite.
> 
> I tried to update this ticket some time ago, but it didn't take.  Here
> is the commit message.
> 
> commit b7502288af31c8825a7da7573538e6ce58a641c3
>  Author: Karl Williamson <khw@cpan.org>
>  Date:   Thu Mar 28 18:22:11 2019 -0600
> 
> PATCH: [perl #133347] Tk broken
> 
> This was caused by utf8_to_uvchr() failing to set the returned ptr
> in some circumstances, leading to reading uninitialized memory.
> 
> A test failure remains, and I'll wait for Slaven's feedback before
> looking further into that.  It is in t/photo.t
> 
> couldn't recognize image data at blib/lib/Tk/Image.pm line 21.
> # Looks like your test exited with 255 just after 100
> 
> And it's trying at that point to look at 'Xcamel.gif'

There are again pass reports for Tk with bleadperl:
http://matrix.cpantesters.org/?dist=Tk%20804.034;perl=5.29.10;reports=1

I cannot reproduce the photo.t failure. Possibly a problem limited to a specific system/perl configuration --- this may be discussed in the Tk RT queue.

From my point of view this ticket may be closed.

Regards,
    Slaven


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=133347

• [perl #133347] BBC SREZIC/Tk-804.034.tar.gz by Karl Williamson via RT
• [perl #133347] BBC SREZIC/Tk-804.034.tar.gz by slaven@rezic.de via RT