develooper Front page | perl.perl5.porters | Postings from April 2019

[perl #133980] t/op/taint.t fails test 846 on Windows

Thread Previous | Thread Next
From:
Steve Hay via RT
Date:
April 19, 2019 16:19
Subject:
[perl #133980] t/op/taint.t fails test 846 on Windows
Message ID:
rt-4.0.24-17188-1555690738-762.133980-15-0@perl.org
On Fri, 12 Apr 2019 11:43:18 -0700, khw wrote:
> On Thu, 04 Apr 2019 10:49:37 -0700, public@khwilliamson.com wrote:
> > On 4/4/19 9:19 AM, Dave Mitchell wrote:
> > > On Thu, Apr 04, 2019 at 07:51:53AM -0600, Karl Williamson wrote:
> > >> I can reproduce it on the WIndows box attached to dromedary.  Is
> > >> there
> > >> something about windows that differs from Linux in regards to
> > >> tainting?
> > >
> > > Nothing that I'm aware of
> > >
> >
> > In particular it is this that isn't getting tainted:
> >
> > local $ENV{XX} = '\p{IsB}';   # Making it an environment variable
> > taints it
> >
> > The other taint tests work that use different ways to taint, such as
> >
> > $prop = "IsA$TAINT";
> > eval { "A" =~ /\p{$prop}/};
> 
> I noticed that elsewhere in this .t, tests for ENV being tainted are
> skipped.  Unskipping them causes them to fail.  The commit that added
> the skip dates from the 1990's as part of an omnibus update, so
> there's no commit message.
> 
> I suspect the answer to this ticket is to skip this test on the same
> platforms the other ENV tests are skipped for.

Now skipped, in commit e8aa9efe194720b3919085f4299f812d661d5d53. Leaving ticket open for now since it would be nice to understand why the skip is necessary.


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=133980

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About