develooper Front page | perl.perl5.porters | Postings from April 2019

[perl #133978] Blead breaks CPAN: ff8b8b42 breaks Jcode

Thread Previous
From:
James E Keenan
Date:
April 3, 2019 11:59
Subject:
[perl #133978] Blead breaks CPAN: ff8b8b42 breaks Jcode
Message ID:
rt-4.0.24-31620-1554292796-359.133978-75-0@perl.org
# New Ticket Created by  James E Keenan 
# Please include the string:  [perl #133978]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org/Ticket/Display.html?id=133978 >


In the course of investigating the status of RT 132577 re 
Module::Install, I happened to notice that blead was breaking Jcode 
version 2.07.  With the following bisection command:

#####
perl Porting/bisect.pl --start=9a15f8566d548de2162909bc3ee39a6486eb616f 
--module=Jcode
#####

... I was able to identify the breaking commit:

#####
ff8b8b424ccfd061181bc857f22fe02ef9a17b9b is the first bad commit
commit ff8b8b424ccfd061181bc857f22fe02ef9a17b9b
Author: Karl Williamson <khw@cpan.org>
Date:   Fri Mar 29 12:57:40 2019 -0600

regexec.c: Use first byte info in ANYOFH

Commit 765e6ecf32a570694dcff91c1c72f98306a9390e changed
ANYOFH regnodes to note if the first byte of all code
points matched is the same. When that is the case we can
potentially speed up matching by only trying to match at
points in the input where that byte occurs. Since ANYOFH
nodes match only UTF-8 encoded strings, that first byte is
going to be a UTF-8 start byte. If that is uncommon in the
target string, this is a real winner.

#####

Some test output:

#####
t/perl581.t .. ok

#   Failed test 'm//'
#   at t/regex.t line 21.
#          got: '¤Ã¤¿'
#     expected: '¤Ò¤é¤¬¤Ê¤Î'
# Looks like you failed 1 test of 7.
t/regex.t ....
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/7 subtests
t/tr.t ....... ok

Test Summary Report
-------------------
t/regex.t  (Wstat: 256 Tests: 7 Failed: 1)
   Failed test:  1
   Non-zero exit status: 1
Files=11, Tests=244,  1 wallclock secs ( 0.05 usr  0.01 sys +  0.67 cusr 
  0.06 csys =  0.79 CPU)
Result: FAIL
#####

Karl, can you take a look?

Thank you very much.
Jim Keenan

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About