develooper Front page | perl.perl5.porters | Postings from April 2019

Re: [perl #133977] Blead breaks CPAN: 657ed7c1 breaks XML::Parser

Thread Previous | Thread Next
From:
Dave Mitchell
Date:
April 3, 2019 10:44
Subject:
Re: [perl #133977] Blead breaks CPAN: 657ed7c1 breaks XML::Parser
Message ID:
20190403104436.GN5208@iabyn.com
On Tue, Apr 02, 2019 at 09:58:03PM -0700, Tony Cook via RT wrote:
> The attached fixes XML::Parser for me.

Thanks for the diagnosis. I've just pushed the following:

commit 06cbc317229e882f379e75eb3adf7cf9c071febd
Author:     David Mitchell <davem@iabyn.com>
AuthorDate: Wed Apr 3 11:06:22 2019 +0100
Commit:     David Mitchell <davem@iabyn.com>
CommitDate: Wed Apr 3 11:06:22 2019 +0100

    Fix recent double free in S_parse_gv_stash_name()
    
    RT #133977
    
    My recent commit v5.29.9-29-g657ed7c1c1 moved all buffer freeing to
    the end of the function, but missed removing one of the existing frees.
    
    The problem was spotted by James E Keenan and diagnosed by Tony Cook; I just
    added a test.
    
    A simple reproducer is
    
    my $def = defined *{"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'x"};

M       gv.c
M       t/op/stash_parse_gv.t


-- 
Hofstadter's Law: It always takes longer than you expect, even when you
take into account Hofstadter's Law.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About