On Thursday 28 March 2019 17:01:47 Tony Cook via RT wrote: > On Thu, 28 Mar 2019 05:58:25 -0700, pali@cpan.org wrote: > > On Tuesday 26 February 2019 10:00:58 pali@cpan.org wrote: > > > On Wednesday 13 February 2019 20:16:03 pali@cpan.org wrote: > > > > On Tuesday 12 February 2019 20:13:42 Tony Cook via RT wrote: > > > > > On Thu, 07 Feb 2019 05:29:14 -0800, pali@cpan.org wrote: > > > > > > And here is patch which makes sv_mortalcopy_flags() function public. > > > > > > > > > > +=for apidoc sv_mortalcopy_flags > > > > > + > > > > > +Like C<sv_mortalcopy>, but the extra C<flags> are passed to the > > > > > +C<sv_setsv_flags>. > > > > > + > > > > > > > > > > SV_GMAGIC is also meaningful for sv_mortalcopy_flags(). > > > > > > > > So... any suggestion how to improve documentation? > > > > > > Tony, ping. What do you prefer or how do you want to improve this change? > > > > ping > > Sorry, I thought this was all resolved (and I was sort of wrong.) > > Since sv_mortalcopy_flags()'s treatment of S_GMAGIC is equivalent to sv_setsv_flags() treatment, I no longer think there's any extra documentation needed. > > I mis-read the code, sorry for my misunderstanding and the delay in the response. Ok, so are there any other changes needed for this patch?Thread Previous | Thread Next