develooper Front page | perl.perl5.porters | Postings from March 2019

[perl #132782] Missing SvPV* utf8/byte nomg macro variants

Thread Previous | Thread Next
From:
Tony Cook via RT
Date:
March 20, 2019 03:59
Subject:
[perl #132782] Missing SvPV* utf8/byte nomg macro variants
Message ID:
rt-4.0.24-18928-1553054362-1522.132782-15-0@perl.org
On Tue, 19 Mar 2019 20:49:46 -0700, tonyc wrote:
> On Tue, 19 Mar 2019 01:55:18 -0700, pali@cpan.org wrote:
> > On Thursday 28 February 2019 15:57:17 pali@cpan.org wrote:
> > > In attachment is V5 version of patches. There is updated
> > > documentation for them.
> > 
> > Tony, can you look at new patch version?
> 
> make test fails.
> 
> There still aren't any vec() tests (see the attached.)
> 
> There's no tests for the new APIs (which can go in ext/XS-APItest/)
> 
> Tony

Also:

-	    int mg_flags = SV_GMAGIC;
+	    int mg_flags = 0;
+
+            if (flags & SV_GMAGIC)
+                mg_flags = SV_GMAGIC;

Can just be:

  int mg_flags = flags & SV_GMAGIC;

but should probably be:

  U32 mg_flags = flags & SV_GMAGIC;

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=132782

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About