On Thu, 14 Feb 2019 01:08:33 -0800, pali@cpan.org wrote: > On Wednesday 13 February 2019 09:36:31 pali@cpan.org wrote: > > On Tuesday 12 February 2019 20:54:11 Tony Cook via RT wrote: > > > On Tue, 12 Feb 2019 07:46:22 -0800, pali@cpan.org wrote: > > > > On Thursday 07 February 2019 16:05:40 pali@cpan.org wrote: > > > > > On Tuesday 22 January 2019 09:38:38 pali@cpan.org wrote: > > > > > > On Monday 21 January 2019 15:03:02 Leon Timmermans via RT > > > > > > wrote: > > > > > > > On Mon, Jan 21, 2019 at 6:51 PM <pali@cpan.org> wrote: > > > > > > > > > > ...and apply remaining > > > > > > > > > > PerlIO::encoding patch? > > > > > > > > > > > > > > > > > > Can you specify which of the patches attached to this > > > > > > > > > RT is > > > > > > > > > the one still under consideration? > > > > > > > > > > > > > > > > 0002-PerlIO-encoding-Use-Encode-ONLY_PRAGMA_WARNINGS-in- > > > > > > > > f.patch > > > > > > > > > > > > > > > > All other patches are part of Encode, and therefore > > > > > > > > applied. > > > > > > > > > > > > > > Can you add a perldelta entry? > > > > > > > > > > > > I do not know where is correct place to put entries, nor what > > > > > > is > > > > > > correct > > > > > > formatting... But entry could contain something like this: > > > > > > > > > > > > === > > > > > > Modules PerlIO::encoding and Encode were fixed to respect > > > > > > state of > > > > > > utf8 > > > > > > pragma warnings when processing filehandle with :encoding > > > > > > layer. > > > > > > === > > > > > > > > > > Leon, it is enough? > > > > > > > > PING > > > > > > Do you mean the patch: > > > > > > - > > > Encode::PERLQQ()|Encode::WARN_ON_ERR()|Encode::STOP_AT_PARTIAL(); > > > + > > > Encode::PERLQQ()|Encode::WARN_ON_ERR()|Encode::ONLY_PRAGMA_WARNINGS()|Encode::STOP_AT_PARTIAL(); > > > > > > > Yes. > > > > > which fails a test: > > > > > > ../ext/PerlIO-encoding/t/fallback.t > > > (Wstat: 256 Tests: 10 Failed: 1) > > > Failed test: 2 > > > Non-zero exit status: 1 > > > > It started failing? Ah :-( IIRC it worked when I created it year ago. > > > > I will look at it... > > Hi! Following patch should fix this problem. There is missing > "use warnings" and also "my $line" is declared more times. I just added use warnings to the block that does the warning test. Thanks, applied your change as 7d0a46b7159e5ac307bcf356572da3501eaee898. Tony --- via perlbug: queue: perl5 status: open https://rt.perl.org/Ticket/Display.html?id=131683