develooper Front page | perl.perl5.porters | Postings from February 2019

Re: RFC: Adding \p{foo=/re/}

Thread Previous | Thread Next
From:
Deven T. Corzine
Date:
February 8, 2019 15:42
Subject:
Re: RFC: Adding \p{foo=/re/}
Message ID:
CAFVdu0SGdS8TRjSkbrzNMh_y-pPYohuD=0KxfwXtsr0Zi5-_VA@mail.gmail.com
On Tue, Feb 5, 2019 at 5:47 PM Karl Williamson <public@khwilliamson.com>
wrote:

> I am proposing to implement this in 5.30.  I already have a working
> prototype, which you can find in
>
> https://perl5.git.perl.org/perl.git/shortlog/refs/heads/smoke-me/khw-core
>

It could use a couple casts to silence compiler warnings...

Deven

diff --git a/regcomp.c b/regcomp.c
index 27efe853c8..b19fab4768 100644
--- a/regcomp.c
+++ b/regcomp.c
@@ -21898,7 +21898,7 @@ Perl_handle_user_defined_property(pTHX_
         }

         do {
-            if (min > (MAX_LEGAL_CP >> 4)) {
+            if (min > (IV)(MAX_LEGAL_CP >> 4)) {
                 s = strchr(s, '\n');
                 if (s == NULL) {
                     s = e;
@@ -21933,7 +21933,7 @@ Perl_handle_user_defined_property(pTHX_
             /* Look for the high point of the range */
             max = 0;
             do {
-                if (max > (MAX_LEGAL_CP >> 4)) {
+                if (max > (IV)(MAX_LEGAL_CP >> 4)) {
                     s = strchr(s, '\n');
                     if (s == NULL) {
                         s = e;

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About