develooper Front page | perl.perl5.porters | Postings from December 2018

Re: regexec.c: LGTM analysis warns about two comparisons, butweactually need them

Thread Previous | Thread Next
From:
Karl Williamson
Date:
December 10, 2018 01:46
Subject:
Re: regexec.c: LGTM analysis warns about two comparisons, butweactually need them
Message ID:
e3de5603-614d-7500-5c67-f35ab49a058b@khwilliamson.com
On 12/9/18 4:08 PM, Tony Cook wrote:
> On Fri, Dec 07, 2018 at 09:20:30PM -0700, Karl Williamson wrote:
>> On 12/6/18 12:54 PM, Karl Williamson wrote:
>>> I have pushed a branch with this commit that changes those numbers to
>>> symbols to make things clear
>>>
>>> https://perl5.git.perl.org/perl.git/commitdiff/ef5a8af164793929880381dcf36b727440050d44
>>
>> The branch has not been pushed to blead as g540fa6e13e.  Hopefully this
>> fixes the LGTM notice, as the hard-coded numbers have been replaced by the
>> appropriate mnemonic.
> 
> I don't expect it to prevent LGTM warning about the code, but
> hopefully the next person who sees the warning will see the note on
> NUM_ANYOF_CODE_POINTS and understand that the two comparisons that
> LGTM complains about aren't necessarily redundant.
> 
> Tony
> 

s/not pushed to blead/now pushed to blead/

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About