develooper Front page | perl.perl5.porters | Postings from December 2018

Re: regexec.c: LGTM analysis warns about two comparisons, butweactually need them

Thread Previous | Thread Next
From:
James E Keenan
Date:
December 6, 2018 13:21
Subject:
Re: regexec.c: LGTM analysis warns about two comparisons, butweactually need them
Message ID:
20181206132050.21392.qmail@lists-nntp.develooper.com
On 12/6/18 3:16 AM, Tony Cook wrote:
> On Wed, Dec 05, 2018 at 10:28:54PM -0500, James E Keenan wrote:
>> Here is a case where the LGTM.com analysis of the Perl 5 source code
>> produces results that are at first plausible but ultimately incorrect.
>>
>> The following section of regexec.c is cited (https://lgtm.com/projects/g/Perl/perl5/alerts/?mode=tree&ruleFocus=2154840804)
>> with the warning-level alert "Comparison result is always the same":
> 
> This was discussed in #133686, the comparison needs to stay to allow
> for local configuration of larger values of NUM_ANYOF_CODE_POINTS.
> 

Would it be okay if I inserted a comment to that effect into regexec.c 
so that we don't stumble upon this again in the future?

Thank you very much.
Jim Keenan

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About