develooper Front page | perl.perl5.porters | Postings from November 2018

Re: [perl #133624] Data::Dumper 2.172 failure on Perl 5.8.8 andolder

Thread Previous | Thread Next
From:
Sawyer X
Date:
November 10, 2018 10:11
Subject:
Re: [perl #133624] Data::Dumper 2.172 failure on Perl 5.8.8 andolder
Message ID:
c0941226-c3ff-ba52-6022-bf3248741f95@gmail.com

On 11/10/18 11:33 AM, Sawyer X wrote:
> On 10/28/18 3:52 PM, James E Keenan via RT wrote:
>> On Sun, 28 Oct 2018 12:38:07 GMT, skaji@cpan.org wrote:
>>> While Data-Dumper-2.161 has DEFINE => '-DUSE_PPPORT_H' in Makefile.PL,
>>> Data-Dumper-2.172 does not.
>>> https://metacpan.org/source/SMUELLER/Data-Dumper-2.161/Makefile.PL#L17
>>> https://metacpan.org/source/XSAWYERX/Data-Dumper-2.172/Makefile.PL
>>>
>>> If I added DEFINE => '-DUSE_PPPORT_H' to Data-Dumper-2.172's
>>> Makefile.PL manually,
>>> I was able to build Data-Dumper-2.172 on perl-5.8.8.
>>>
>> An excellent insight!  I can confirm that modifying the Makefile.PL in Data-Dumper-2.172's Makefile.PL enabled me to run 'make' and 'make test' and get a PASS.
>>
>> I then built and force-installed a perl-5.8.4 via perlbrew, installed the latest Test::More against that perl, then attempted to install Data-Dumper-2.172.  As grinnz originally reported, 'make' failed.  However, when I edited the Makefile.PL in the manner suggested, 'make' completed and 'make test' was graded PASS.
>>
>> So it appears we need a new CPAN release of Data::Dumper with a corrected Makefile.PL.
>>
>> Sawyer, can you handle that?
>
> I'm not sure why the diff is there.
>
>
> I'll rebuild and release today.


And done.


I also pushed to blead the bump in version. The commit itself explains
the problem with releasing Data::Dumper, as the Makefile.PL is
auto-generated and the MANIFEST.SKIP is excluded. I'm not familiar
enough with the magical "we create Makefile.PL for all dist/" system so
I won't attempt to fix it at the moment. I just described my process so
it could be repeated by others.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About