develooper Front page | perl.perl5.porters | Postings from October 2018

[perl #133584] Fatalize unqualified use of dump() in perl-5.30

Thread Next
From:
James E Keenan via RT
Date:
October 13, 2018 03:27
Subject:
[perl #133584] Fatalize unqualified use of dump() in perl-5.30
Message ID:
rt-4.0.24-13358-1539401257-1886.133584-15-0@perl.org
On Sat, 13 Oct 2018 03:13:34 GMT, jkeenan@pobox.com wrote:
> In the following commit we we implemented a warning, present in 
> perl-5.28, that as of perl-5.30 dump() would no longer be supported 
> unless it was invoked as CORE::dump().
> 
> #####
> commit 30b17cc1e1a4683734a35a2fc7416f1ef34f4e5d
> Author:     Abigail <abigail@abigail.be>
> AuthorDate: Fri Jan 13 22:36:47 2017 +0100
> Commit:     Abigail <abigail@abigail.be>
> CommitDate: Mon Jan 16 19:18:15 2017 +0100
> 
>      Deprecation of an unqualified dump() to mean CORE::dump().
> 
>      This will no longer be allowed in 5.30.
> #####
> 
> In preparation for perl-5.30, we need to fatalize the unqualified use of 
> dump() and adjusts tests and documentation accordingly.
> 
> Thank you very much.
> Jim Keenan

A draft of an implementation of the fatalization of unqualified dump() can be found in the smoke-me/jkeenan/133584-dump-becomes-core-dump branch  or in the attached diff (which squashes all the patches in that branch).

Please review the patch, particularly with respect to the following:

1. toke.c:  Correct usage of Perl_croak; suitability of error message.

2. Tests:

3. Documentation:

Please review carefully. If satisfactory, I would like to merge to blead by Thursday, October 17, so that we can get it into the monthly release scheduled for October 20 and then see how much CPAN breakage occurs.

Thank you very much.
-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: new
https://rt.perl.org/Ticket/Display.html?id=133584

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About