develooper Front page | perl.perl5.porters | Postings from October 2018

[perl #133557] Build-time warnings: 'Wparentheses' generated byg++-8

Thread Previous | Thread Next
From:
James E Keenan via RT
Date:
October 10, 2018 13:27
Subject:
[perl #133557] Build-time warnings: 'Wparentheses' generated byg++-8
Message ID:
rt-4.0.24-4306-1539178029-1588.133557-15-0@perl.org
On Tue, 09 Oct 2018 21:12:12 GMT, jkeenan wrote:
> On Wed, 03 Oct 2018 19:20:40 GMT, jkeenan@pobox.com wrote:
> > If we use g++-8 to build blead, we get a variety of warnings including 3 
> > in the 'Wparentheses' category.
> > 
> > #####
> > $ zgrep 'warning:' linux.make.v5.29.3-25-g65104f4cf7.output.txt.gz | 
> > perl -n -E 'chomp;($x) = $_ =~ m{.*\[(.*)]$};say $x;' | sort | uniq -c
> >        6 -Wcast-function-type
> >        2 -Wclobbered
> >        2 -Wformat-overflow=
> >        4 -Wignored-qualifiers
> >       33 -Wimplicit-fallthrough=
> >        1 -Wmultistatement-macros
> >        3 -Wparentheses
> >        3 -Wpragmas
> > #####
> > 
> > This can be seen, for example, in this smoke-test report: 
> > http://perl.develop-help.com/raw/?id=215137
> > 
> > These 3 warnings can be silence easily.  I created the 
> > smoke-me/jkeenan/Wparentheses branch last week for this purpose.  The 
> > warnings are gone.
> > 
> > #####
> > $ zgrep 'warning:' make.Wparentheses.output.txt.gz | perl -n -E 
> > 'chomp;($x) = $_ =~ m{.*\[(.*)]$};say $x;' | sort | uniq -c
> >        7 -Wcast-function-type
> >        2 -Wclobbered
> >        2 -Wformat-overflow=
> >        4 -Wignored-qualifiers
> >       33 -Wimplicit-fallthrough=
> >        1 -Wmultistatement-macros
> >        3 -Wpragmas
> > #####
> > 
> > This can also be seen in this smoke-test report (which I believe was run 
> > on the same machine as the preceding one): 
> > http://perl.develop-help.com/raw/?id=215124
> > 
> > Please review the patch attached: 
> > 0001-Eliminated-3-Wparentheses-warnings-detected-by-g-8.patch
> > 
> 
> I'll apply this patch tomorrow unless I hear otherwise.
> 
> Thank you very much.

Applied to blead in commit fc917fff56.

-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=133557

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About