develooper Front page | perl.perl5.porters | Postings from September 2018

Re: Pull request to upgrade CPAN.pm to 1.21-TRIAL

Thread Previous | Thread Next
From:
Achim Gratz
Date:
September 29, 2018 18:55
Subject:
Re: Pull request to upgrade CPAN.pm to 1.21-TRIAL
Message ID:
87h8i8uoak.fsf@Rainer.invalid
Andreas,

could you perhaps also fix the single blank line output that
initializing CPAN does when it's not having to report anything?  I've
had it fixed locally (don't know if the patch still applies), but since
I moved back to the built-in version it's doing it again of course.

--- origsrc/CPAN-2.14/lib/CPAN.pm	2016-06-04 15:46:05.000000000 +0200
+++ src/CPAN-2.14/lib/CPAN.pm	2017-01-03 15:39:58.099383700 +0100
@@ -90,11 +90,13 @@ if ($ENV{PERL5_CPAN_IS_RUNNING} && $$ !=
         warn $w;
     }
     local $| = 1;
+    my $have_been_sleeping = 0;
     while ($sleep > 0) {
         printf "\r#%5d", --$sleep;
         sleep 1;
+	++$have_been_sleeping;
     }
-    print "\n";
+    print "\n" if $have_been_sleeping;
 }
 $ENV{PERL5_CPAN_IS_RUNNING}=$$;
 $ENV{PERL5_CPANPLUS_IS_RUNNING}=$$; # https://rt.cpan.org/Ticket/Display.html?id=23735


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About